fix: optimize DropReason eBPF map lookups #730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For all eBPF program in the DropReason plugin (except
inet_csk_accept
which has issue we need to investigate #715):memset
is called on the entire structDetails:
Previously, we did a map lookup regardless of whether the input
retVal
indicated a drop. Now, only for drops.We also skip a map delete when there wasn't a earlier kprobe that saved the corresponding PID.
Checklist
git commit -S -s ...
). See this documentation on signing commits.