Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: annotation tag in documentation #654

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

alexcastilio
Copy link
Contributor

Description

Annotation in this page is different than here and it does not work correctly.

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@alexcastilio alexcastilio added area/documentation Improvements or additions to documentation type/fix Fixes something labels Aug 26, 2024
@alexcastilio alexcastilio self-assigned this Aug 26, 2024
@alexcastilio alexcastilio requested a review from a team as a code owner August 26, 2024 10:45
@alexcastilio alexcastilio changed the title Fix annotation fix: annotation tag in documentation Aug 26, 2024
timraymond
timraymond previously approved these changes Aug 27, 2024
Copy link
Member

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this if it reflects reality. Although we should think if we should deprecate this usage and change the annotation to include the v1aplha part. @anubhabMajumdar ? What do you think?

Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
@anubhabMajumdar
Copy link
Contributor

Happy to approve this if it reflects reality. Although we should think if we should deprecate this usage and change the annotation to include the v1aplha part. @anubhabMajumdar ? What do you think?

Approved the PR since the usage has change to retina.sh=observe. I think the usage was updated so that it's not API version dependent.

@alexcastilio alexcastilio added this pull request to the merge queue Sep 4, 2024
Merged via the queue into microsoft:main with commit 309842b Sep 4, 2024
22 checks passed
@alexcastilio alexcastilio deleted the fix-annotation branch September 4, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation type/fix Fixes something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants