fix: Implement a dynamic temporary cache that tracks network interfaces that do not support the ethtool operation. #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaozhiche320
changed the title
|
@xiaozhiche320 please review the contributing guidelines, in particular signing and signing-off, and also update or remove the boilerplate in the description so that it is accurate. |
timraymond
requested changes
Aug 19, 2024
vakalapa
reviewed
Aug 20, 2024
nddq
reviewed
Aug 23, 2024
timraymond
reviewed
Aug 23, 2024
nddq
reviewed
Aug 26, 2024
nddq
reviewed
Aug 27, 2024
matmerr
approved these changes
Aug 27, 2024
timraymond
approved these changes
Aug 27, 2024
xiaozhiche320
force-pushed
the
fix_ethtool
branch
from
f1c59ee
to
5f43e70
Compare
2.Implement a dynamic temporary cache that tracks network interfaces that do not support the ethtool operation. 3.Add new test cases for the new changings
xiaozhiche320
force-pushed
the
fix_ethtool
branch
from
5f43e70
to
48e6a60
Compare
nddq
approved these changes
Aug 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
7 tasks
| @@ -318,10 +318,10 @@ func (p *packetParser) clean(tcnl ITc, tcIngressObj *tc.Object, tcEgressObj *tc. | |||
| // Warning, not error. Clean is best effort. | |||
| if tcnl != nil { | |||
| if err := getQdisc(tcnl).Delete(tcEgressObj); err != nil && !errors.Is(err, tc.ErrNoArg) { | |||
There was a problem hiding this comment.
We should check if the error is because theveth was deleted. If that's the case, it's not an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.Implement a dynamic temporary cache that tracks network interfaces that do not support the ethtool operation.
2.Add new test cases for the new changings
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.