Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add support for react-native 0.57 #797

Closed
luisnaranjo733 opened this issue Sep 7, 2018 · 9 comments
Closed

[Feature request] Add support for react-native 0.57 #797

luisnaranjo733 opened this issue Sep 7, 2018 · 9 comments

Comments

@luisnaranjo733
Copy link
Member

luisnaranjo733 commented Sep 7, 2018

React-native 0.57 is close to being released, and it is looking like this will be a major release that a lot of people will want to switch to as quickly as possible.

Here are a few of those compelling reasons....

I think there is value in starting work on this ASAP to unblock the migration to 0.57 for XP's user base. Has there been any effort/investigation to support RN 0.57? Facebook has already put out several release candidates that can be used for this investigation.

@erictraut
Copy link
Contributor

The Skype team hasn't done any investigation on RN 0.57 yet. It would be great if someone in the ReactXP community could help with this. Let me know if you see any incompatibilities. We haven't had any problems reported with any recent updates to RN, but if this is a major release, the chances of breaking changes increases.

@luisnaranjo733
Copy link
Member Author

I have some time planned to start working on the 0.57 migration in ~3 weeks. By then, a stable 0.57 will likely have been released. I will surely discover breaking changes at that point if they exist. If so, I will happily help file issues and make PRs.

@reseul
Copy link
Contributor

reseul commented Sep 19, 2018

I'm in line with the RN for Windows 0.57...

@fbartho
Copy link
Contributor

fbartho commented Oct 18, 2018

I'm currently working on it for my team. I haven't gotten Jest to work yet, but I think I can get ReactXP to work on device/Simulator.

@luisnaranjo733
Copy link
Member Author

Circling back here - I've migrated my team's project to RN 0.57 with XP. There were some hiccups but they were mostly unrelated to XP.

The only issue I've found is this, and even that might be a RN issue (haven't had time to investigate)
#850

The other thing is that accessibility APIs have changed in RN 0.57. I haven't compared the XP types to the RN types, but it seems likely that the XP API is out of date. I have not investigated this yet either.

@fbartho
Copy link
Contributor

fbartho commented Oct 22, 2018

My status update: I have the app mostly working, but not fully working with jest yet.

Currently: ironing out some changes in react-navigation, then will resume getting jest to work.

@fbartho
Copy link
Contributor

fbartho commented Oct 22, 2018

Looks like everything is working now, with no changes from reactxp needed! I'm happy to help whomever is still struggling with this.

@luisnaranjo733
Copy link
Member Author

Going to go ahead and close this issue since we know now that there are no major hurdles to overcome here. If there are any regressions, we can file issues as they are discovered.

Thanks everyone!

@erictraut
Copy link
Contributor

Thanks for doing the investigation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants