Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components under "display: none" still participate in focus, UIA, etc #6355

Closed
NickGerleman opened this issue Oct 28, 2020 · 1 comment · Fixed by #7363
Closed

Components under "display: none" still participate in focus, UIA, etc #6355

NickGerleman opened this issue Oct 28, 2020 · 1 comment · Fixed by #7363
Assignees
Milestone

Comments

@NickGerleman
Copy link
Collaborator

RNW will pass the "display: none" property to Yoga for layout, but doesn't take it into consideration for XAML visibility. This means we create the same XAML tree as normal, but elements are hidden by virtue of being sized as (0,0).

Because of this, components under "display: none" still participate in UIA, focus, or other bits that they likely shouldn't. @kmelmon mentioned this also defeats certain XAML perf optimizations. Concretely, this causes issues with RNTester refactoring, leading to multiple UIA elements with the same automation ID to be displayed at once.

We should propagate this to the XAML tree (maybe just mark the tree as collapsed?).

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Oct 28, 2020
@acoates-ms
Copy link
Contributor

+1 Sounds like we should set Visibility=Hidden when display: none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants