Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNTester RTLExample page is broken on Windows #4646

Closed
kmelmon opened this issue Apr 20, 2020 · 1 comment · Fixed by #4683
Closed

RNTester RTLExample page is broken on Windows #4646

kmelmon opened this issue Apr 20, 2020 · 1 comment · Fixed by #4683
Assignees
Labels

Comments

@kmelmon
Copy link
Contributor

kmelmon commented Apr 20, 2020

In RNTester, go to the RTLExample page.

Notice: Nothing happens when you click on any of the buttons that toggle between LTR and RTL.

I debugged this a bit. There are multiple problems that prevent this page from working on Windows:
-There's a central function that toggles between rtl/ltr, this function only does anything on iOS.
-Even after fixing the above, direction never toggles.

This needs to be further debugged and fixed. As it stands this page isn't useful on Windows.

@kmelmon kmelmon added the bug label Apr 20, 2020
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 20, 2020
@kmelmon kmelmon self-assigned this Apr 20, 2020
@kmelmon
Copy link
Contributor Author

kmelmon commented Apr 20, 2020

I'll take this as I'm fixing several RTL related issues

@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants