Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): support for custom Package.appxmanifest #302

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 1, 2021

Description

Picks up the Package.appxmanifest placed next to the generated .sln.

Resolves #224.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

  1. Generate the solution:
    cd example
    yarn
    yarn install-windows-test-app
    start windows/Example.sln
    
  2. Observe that Package.appxmanifest is the same as the one from react-native-test-app.
  3. Close Visual Studio.
  4. Copy /windows/ReactTestApp/Package.appxmanifest ito /example/windows
  5. Modify /example/windows/Package.appxmanifest, e.g. change the display name to Example
  6. Open app.json and add the following:
    diff --git a/example/app.json b/example/app.json
    index 8463354..941fa30 100644
    --- a/example/app.json
    +++ b/example/app.json
    @@ -29,5 +29,8 @@
           "dist/assets",
           "dist/main.windows.bundle"
         ]
    +  },
    +  "windows": {
    +    "appxManifest": "windows/Package.appxmanifest"
       }
     }
  7. Regenerate the solution: yarn install-windows-test-app
  8. Open the new Visual Studio solution
  9. Observe that the display name is now Example

Docs have been updated to include the new property: https://github.com/microsoft/react-native-test-app/wiki/Manifest-(app.json)#appxmanifest

@tido64 tido64 added the platform: Windows This affects Windows label Apr 1, 2021
@tido64 tido64 requested review from kelset and tom-un April 1, 2021 12:37
@tido64 tido64 force-pushed the tido/custom-appxmanifest branch 4 times, most recently from 4d2516c to 892b635 Compare April 10, 2021 20:11
@tido64 tido64 force-pushed the tido/custom-appxmanifest branch from 892b635 to 8754948 Compare April 10, 2021 20:29
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tido64 tido64 merged commit 76286ee into master Apr 13, 2021
@tido64 tido64 deleted the tido/custom-appxmanifest branch April 13, 2021 10:12
@github-actions
Copy link

🎉 This PR is included in version 0.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows This affects Windows released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: Add ability to provide own certificate for package signing
2 participants