Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): revert "always include ReactNative-application.cmake on 0.76" #2341

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(android): revert "always include ReactNative-application.cmake on 0.76" #2341

merged 1 commit into from
Dec 10, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Dec 9, 2024

Description

This causes old architecture build failure.

Reverts #2310.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

CI should pass.

@tido64 tido64 requested a review from Saadnajmi December 9, 2024 14:03
@tido64 tido64 requested a review from JasonVMo as a code owner December 9, 2024 14:03
@github-actions github-actions bot added the platform: Android This affects Android label Dec 9, 2024
@tido64 tido64 mentioned this pull request Dec 10, 2024
Merged
11 tasks
@tido64 tido64 merged commit 45eabdb into trunk Dec 10, 2024
30 checks passed
@tido64 tido64 deleted the tido/android/fix-old-arch branch December 10, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
platform: Android This affects Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @Saadnajmi