Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix configure-test-app crashing on 0.75 #2190

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Aug 19, 2024

Description

Fixes configure-test-app crashing on 0.75

Resolves #2187

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version 0.75 -- --core-only
yarn
cd example
yarn configure-test-app -p android -p ios -p macos -p visionos -p windows

Expected output:

Downloading template-0.75.1.tgz...
[!] react-native-macos@0.75 cannot be added because it does not exist or is unsupported
[!] The following files will be overwritten:
     .gitignore
     .watchmanconfig
     android/build.gradle
     android/gradle.properties
     android/gradle/wrapper/gradle-wrapper.jar
     android/gradle/wrapper/gradle-wrapper.properties
     android/gradlew
     android/gradlew.bat
     android/settings.gradle
     babel.config.js
     ios/Podfile
     metro.config.js
     react-native.config.js
     visionos/Podfile
     windows/.gitignore
[!] The following files will be removed:
     ios/Podfile.lock
     visionos/Podfile.lock
[!] Destructive file operations are required.
Re-run with --force if you're fine with this.

If you run the last command again, we should no longer download the template.

@tido64 tido64 requested a review from JasonVMo as a code owner August 19, 2024 14:34
@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows platform: visionOS labels Aug 19, 2024
@tido64 tido64 merged commit aa634df into trunk Aug 21, 2024
30 checks passed
@tido64 tido64 deleted the tido/fix-configure-test-app branch August 21, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS platform: Windows This affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure-test-app command assumes template lives in react-native core
2 participants