From 45eabdb37f5e347776117cc30f0d1695d9686fa3 Mon Sep 17 00:00:00 2001 From: Tommy Nguyen <4123478+tido64@users.noreply.github.com> Date: Tue, 10 Dec 2024 16:57:42 +0100 Subject: [PATCH] fix(android): revert "always include `ReactNative-application.cmake` on 0.76" (#2341) This reverts commit c1a56a7665aadbf5282b90e4186df5eddd5ff13a. --- android/app/build.gradle | 2 +- android/app/src/main/jni/AutolinkingCompat.h | 6 +----- android/app/src/main/jni/ComponentsRegistry.cpp | 2 -- android/app/src/main/jni/OnLoad.cpp | 4 ---- android/app/src/main/jni/TurboModuleManagerDelegate.cpp | 2 -- 5 files changed, 2 insertions(+), 14 deletions(-) diff --git a/android/app/build.gradle b/android/app/build.gradle index eecb10916..7fe483398 100644 --- a/android/app/build.gradle +++ b/android/app/build.gradle @@ -108,7 +108,7 @@ android { resValue "string", "app_name", project.ext.react.appName def cppStd = reactNativeVersion >= v(0, 74, 0) ? "-std=c++20" : "-std=c++17" - if (reactNativeVersion >= v(0, 76, 0) || enableNewArchitecture) { + if (enableNewArchitecture) { externalNativeBuild { cmake { arguments "-DANDROID_STL=c++_shared", diff --git a/android/app/src/main/jni/AutolinkingCompat.h b/android/app/src/main/jni/AutolinkingCompat.h index 14cf36ba3..6095fb30d 100644 --- a/android/app/src/main/jni/AutolinkingCompat.h +++ b/android/app/src/main/jni/AutolinkingCompat.h @@ -9,7 +9,7 @@ #define autolinking_cxxModuleProvider facebook::react::autolinking_cxxModuleProvider #define autolinking_registerProviders facebook::react::autolinking_registerProviders -#elif __has_include() // < 0.75 +#else // < 0.75 #include @@ -17,10 +17,6 @@ #define autolinking_cxxModuleProvider facebook::react::rncli_cxxModuleProvider #define autolinking_registerProviders facebook::react::rncli_registerProviders -#else // Autolinking is handled elsewhere in the old architecture (paper) - -#define REACTAPP_LEGACY_AUTOLINKING 1 - #endif // __has_include() #endif // REACTAPP_JNI_AUTOLINKINGCOMPAT_H_ diff --git a/android/app/src/main/jni/ComponentsRegistry.cpp b/android/app/src/main/jni/ComponentsRegistry.cpp index 7c02b37d5..83fa11687 100644 --- a/android/app/src/main/jni/ComponentsRegistry.cpp +++ b/android/app/src/main/jni/ComponentsRegistry.cpp @@ -32,10 +32,8 @@ void ComponentsRegistry::registerNatives() facebook::react::DefaultComponentsRegistry::registerComponentDescriptorsFromEntryPoint = [](std::shared_ptr registry) { -#ifndef REACTAPP_LEGACY_AUTOLINKING // Register providers generated by `@react-native-community/cli` autolinking_registerProviders(registry); -#endif // !REACTAPP_LEGACY_AUTOLINKING }; } diff --git a/android/app/src/main/jni/OnLoad.cpp b/android/app/src/main/jni/OnLoad.cpp index 2e1ffb883..526f82eb6 100644 --- a/android/app/src/main/jni/OnLoad.cpp +++ b/android/app/src/main/jni/OnLoad.cpp @@ -19,7 +19,6 @@ using facebook::react::TurboModule; namespace { -#ifndef REACTAPP_LEGACY_AUTOLINKING std::shared_ptr cxxModuleProvider(const std::string &name, const std::shared_ptr &jsInvoker) { @@ -43,18 +42,15 @@ namespace // And we fallback to the module providers autolinked by RN CLI return autolinking_ModuleProvider(name, params); } -#endif // !REACTAPP_LEGACY_AUTOLINKING } // namespace JNIEXPORT jint JNICALL JNI_OnLoad(JavaVM *vm, void *) { return facebook::jni::initialize(vm, [] { -#ifndef REACTAPP_LEGACY_AUTOLINKING DefaultTurboModuleManagerDelegate::cxxModuleProvider = &cxxModuleProvider; DefaultTurboModuleManagerDelegate::javaModuleProvider = &javaModuleProvider; DefaultComponentsRegistry::registerComponentDescriptorsFromEntryPoint = &autolinking_registerProviders; -#endif // !REACTAPP_LEGACY_AUTOLINKING }); } diff --git a/android/app/src/main/jni/TurboModuleManagerDelegate.cpp b/android/app/src/main/jni/TurboModuleManagerDelegate.cpp index 8983cfd72..0ce690ef5 100644 --- a/android/app/src/main/jni/TurboModuleManagerDelegate.cpp +++ b/android/app/src/main/jni/TurboModuleManagerDelegate.cpp @@ -28,13 +28,11 @@ std::shared_ptr TurboModuleManagerDelegate::getTurboModule(StringRe std::shared_ptr TurboModuleManagerDelegate::getTurboModule( StringRef name, const JavaTurboModule::InitParams ¶ms) { -#ifndef REACTAPP_LEGACY_AUTOLINKING // Try autolinked module providers first auto module = autolinking_ModuleProvider(name, params); if (module != nullptr) { return module; } -#endif // !REACTAPP_LEGACY_AUTOLINKING return rncore_ModuleProvider(name, params); }