Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin is broken on iOS when using RN 0.20.0-rc1 (Android works fine) #193

Closed
geof90 opened this issue Feb 10, 2016 · 7 comments
Closed

Plugin is broken on iOS when using RN 0.20.0-rc1 (Android works fine) #193

geof90 opened this issue Feb 10, 2016 · 7 comments

Comments

@geof90
Copy link
Contributor

geof90 commented Feb 10, 2016

Link to the related issue: facebook/react-native#5851
@skevy
Copy link

skevy commented Feb 10, 2016

FYI: facebook/react-native@c9a1956

@lostintangent
Copy link
Member

@skevy Awesome! Thanks for the heads up. Any idea if this will make it into 0.20.0 "RTM"?

@skevy
Copy link

skevy commented Feb 10, 2016

Hmm. Probably should. Let me check on that and I'll report back.

@skevy
Copy link

skevy commented Feb 10, 2016

Added: facebook/react-native#5762

@lostintangent
Copy link
Member

Beautiful! Thanks so much @skevy!

@skevy
Copy link

skevy commented Feb 10, 2016

Np. This fix got turned around pretty quickly...but if you ever have a critical bug in the future, don't hesitate to ping me on the issue/PR. Sometimes super critical stuff can get lost in the fray. Code-push is great...want to make sure we keep it running with each release :)

@lostintangent lostintangent changed the title Plugin is broken in RN 0.20.0-rc due to a change in what RCTPromiseResolveBlock expects Plugin is broken on iOS when using RN 0.20.0-rc1 (Android works fine) Feb 10, 2016
@geof90
Copy link
Contributor Author

geof90 commented Feb 16, 2016

Closing. The latest RN release includes the RCTPromise fix.

@geof90 geof90 closed this as completed Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lostintangent @skevy @geof90