Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new environment variables API #3558

Closed
karrtikr opened this issue Oct 31, 2022 · 6 comments
Closed

Use new environment variables API #3558

karrtikr opened this issue Oct 31, 2022 · 6 comments
Assignees
Labels
engineering needs investigation Could be an issue - needs investigation

Comments

@karrtikr
Copy link

Instead of using the temporary hack to get environment variables, use microsoft/vscode-python#20056.

cc/ @heejaechang

@rchiodo
Copy link
Contributor

rchiodo commented Oct 31, 2022

Is this related to the client move?

@debonte debonte added the waiting for user response Requires more information from user label Oct 31, 2022
@karrtikr
Copy link
Author

karrtikr commented Nov 1, 2022

Yes

@judej judej added triage-needed and removed waiting for user response Requires more information from user labels Dec 4, 2022
@judej judej added needs investigation Could be an issue - needs investigation and removed triage-needed labels Dec 15, 2022
@debonte
Copy link
Contributor

debonte commented Apr 11, 2023

@heejaechang, I see this issue was moved to "Done". Can it be closed?

@heejaechang
Copy link
Contributor

there is one more place we can use it (server using the API through custom LSP to resolve env variables) or we resolve things like $workspaceroot in the middleware. but that work is separate work I guess.

@heejaechang
Copy link
Contributor

this specific issue is done. this one is about pythonPath

@karrtikr
Copy link
Author

this specific issue is done. this one is about pythonPath

I opened this for environment variable API, pythonPath is separate.

But I guess we can close this in favor of https://github.com/microsoft/pyrx/issues/3376.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering needs investigation Could be an issue - needs investigation
Projects
None yet
Development

No branches or pull requests

5 participants