Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Full page screenshots​ doesn't work on Electron application #11041

Closed
nabil-brn opened this issue Dec 21, 2021 · 4 comments
Closed

[BUG] Full page screenshots​ doesn't work on Electron application #11041

nabil-brn opened this issue Dec 21, 2021 · 4 comments

Comments

@nabil-brn
Copy link

Context:

  • Playwright Version: 1.17.0
  • Operating System: Windows, Linux and Mac
  • Node.js version: 14.18.1
  • Browser: Chromium (Electron)
  • Extra: N/A

Code Snippet

import test from "../fixtures/common";
import { expect } from "@playwright/test";
import { OnboardingPage } from "../models/OnboardingPage";

test("Onboarding", async ({ page }) => {
  const onboardingPage = new OnboardingPage(page);

  await test.step("Get started", async () => {
    expect(await onboardingPage.getStartedButton).toBeVisible();
    expect(await page.screenshot({ fullPage: true })).toMatchSnapshot(`getstarted.png`);
  });
})

Describe the bug
On Electron application, I unfortunately can't take a screenshot of the full page.
https://playwright.dev/docs/screenshots#full-page-screenshots

@yury-s
Copy link
Member

yury-s commented Dec 21, 2021

Can you share minimal repro? I've tried with the attached app and it works just fine
test.zip

Also which Electon version are you using?

@nabil-brn
Copy link
Author

Hello @yury-s,

We're using electron version 13.5.2, it could come from our app, I guess?

@aslushnikov
Copy link
Contributor

@nabil-brn this is unfortunately not actionable without a repro that we can run & debug locally. Please feel free to resubmit once there's a repro!

@davej
Copy link

davej commented Nov 11, 2022

Just FYI in case anybody comes across this, the problem with the original is that there was no window selected to screenshot. I made the same mistake.

-    expect(await page.screenshot({ fullPage: true })).toMatchSnapshot(`getstarted.png`);
+    expect(await onboardingPage.screenshot({ fullPage: true })).toMatchSnapshot(`getstarted.png`);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants