Creation of dynamic property is deprecated with PHP 8.2+

[opitz]

To see the issue run a Moodle instance on PHP 8.2 with local_o356 installed.
Log in as admin, set debugging to developer and (try to) open to the plugin overview page.

You will see an error:
Creation of dynamic property local_o365\adminsetting\tabs::$component is deprecated
A similar issue appears with ...\tabs::$theme.

This can be fixed by explicitly declaring $component and $theme in the constructor method.

[weilai-irl]

Hi @opitz

Could you paste the full stack trace of the error/warning please? I can't seem to find where the errors would be triggered.

Regards,
Lai

[opitz]

Hi @weilai-irl ,
sorry for the delayed response, only spotted this today...

1st: the issue only appears with PHP 8.2+.
To see the issue you need to set debugging to DEVELOPER and allow showing errors on screen (or dig through the log).

Then click "Site administration" from the main menu to open this page: http://moodle_root_here/admin/search.php.
On top of the page you should see:

Deprecated: Creation of dynamic property local_o365\adminsetting\tabs::$theme is deprecated in /var/www/html/local/o365/classes/adminsetting/tabs.php on line 68

Deprecated: Creation of dynamic property local_o365\adminsetting\tabs::$component is deprecated in /var/www/html/local/o365/classes/adminsetting/tabs.php on line 67

Deprecated: Creation of dynamic property local_o365\adminsetting\tabs::$theme is deprecated in /var/www/html/local/o365/classes/adminsetting/tabs.php on line 68

To resolve this you will need to declare the properties before you use them. For this simply add

/**
 * @var mixed the component.
 */
protected $component;

/**
 * @var string the theme.
 */
protected $theme;

to the 'tabs' class after line 50 of local/o365/classes/adminsetting/tabs.php.

Best,
m!

[weilai-irl]

@opitz

Thank you for the updates and providing the solution.

I have created PR for Moodle 4.2 and 4.3, and they will be included in the next release. Moodle 4.1 doesn't support PHP 8.2, so the fix doesn't apply there.

Regards,
Lai

[weilai-irl]

Hi @opitz

The fix to this issue has been included in release 4.1.7, 4.2.6 and 4.3.4 on 2nd of July 2024.

Thank you again for reporting the issue and providing the solution.

Regards,
Lai