Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moodle username digits only and azure ad sync not working #2457

Closed
gavrielsl opened this issue Jan 21, 2024 · 3 comments · Fixed by #2517, #2518 or #2519
Closed

moodle username digits only and azure ad sync not working #2457

gavrielsl opened this issue Jan 21, 2024 · 3 comments · Fixed by #2517, #2518 or #2519
Assignees
Labels
Feature - user sync Issue type - help wanted General questions on how to use the plugins, e.g. configurations etc. Plugin - local_o365 Status - PR ready / pending release Dev is done and PR ready. Will be included in the next release.
Milestone

Comments

@gavrielsl
Copy link

gavrielsl commented Jan 21, 2024

Hello,
We run into an issue that we have moodle accounts with digits only (ex 494334334) (student id numbers) and diffrent mail for each student like (test@gmail.com)
we add o365 to integration with our institution that all users start with 494334334@student.onmicrosoft.com
we noticed that the user sync not working for those users and we have a lot of them.

configuration is like that
image

we add some logs to try to find the problem

image

we found that this array
image

not found the objects that contain upn with numbers only

this is the dump object from existing users array

image

can you help us to understand what we can do to fix that issue

@weilai-irl weilai-irl self-assigned this Jan 30, 2024
@weilai-irl
Copy link
Collaborator

Hi @gavrielsl

Thank you for reporting the issue. I remember we had issues with users having digits only usernames previously. I'll try to confirm the issue reported and if confirmed, provide a solution soon.

Regards,
Lai

@weilai-irl weilai-irl added Issue type - help wanted General questions on how to use the plugins, e.g. configurations etc. Status - In Progress WIP Feature - user sync Plugin - local_o365 labels Jan 30, 2024
@gavrielsl
Copy link
Author

@weilai-irl we fix the issue also we will pull request it.

the problem was the index of the array, when you have numbers the index is destroyed after the array_marge.

our solution was to add 0 digit to the username in the existingusers array.

@weilai-irl
Copy link
Collaborator

@gavrielsl

The fix to the reported issue has been included in the release from today.

Thank you very much for reporting the issue.

Regards,
Lai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment