Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.exe path should support relative paths #297

Closed
alejandro5042 opened this issue Jul 17, 2015 · 5 comments
Closed

Node.exe path should support relative paths #297

alejandro5042 opened this issue Jul 17, 2015 · 5 comments

Comments

@alejandro5042
Copy link

I upgraded from 1.1 Beta to the 7-15-2015 dev build and reopened my solution and was unable to run it.

I had a relative path in the project settings under "Node.exe path". I use the electron pre-built package which installs the executable under node_modules\electron-prebuilt\dist\electron.exe relative to the project. It used to work but no longer does.

Specifying a relative path is key in allowing us to submit the .njsproj file into source control and having others be able to debug/run the project without having to modify the project file to specify an absolute path on their machines.

@mousetraps
Copy link
Contributor

I'm pretty sure we never supported this because we haven't really changed anything in this codepath, and the current code would always produce an error if File.Exists returned false on the relative path (running without the debugger attached, however, does work.) In any case, working on a fix that explicitly adds this support.

@mousetraps
Copy link
Contributor

Also are you sure you weren't relying on the functionality described in the following link?
https://nodejstools.codeplex.com/workitem/1533

And just to be clear... I'm not denying that it used to work before... Just saying that I am very surprised if it did 😃

@mousetraps mousetraps changed the title Node.exe path should support relative paths (again) Node.exe path should support relative paths Jul 27, 2015
@alejandro5042
Copy link
Author

Interesting. I checked my the project file history in source control and--surprisingly, I suppose--did not have an absolute path before the upgrade and it surely worked!

<NodeExePath>node_modules\electron-prebuilt\dist\electron.exe</NodeExePath>

Thank you for officially adding this feature! A small change but a major win :)

@alejandro5042
Copy link
Author

Thanks @mousetraps! This will be used every day here.

@mousetraps
Copy link
Contributor

Np, mind trying the latest dev build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants