Update Platform CI for -a flag removal #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
os-d
approved these changes
Jun 3, 2024
Javagedes
reviewed
Jun 3, 2024
Passes the architecture for platform builds through the build flags. For compatibility with the v10.0.0 Mu DevOps release: https://github.com/microsoft/mu_devops/releases/tag/v10.0.0 Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
github-actions
bot
added
the
language:python
apop5
approved these changes
Jun 3, 2024
This was referenced Jun 3, 2024
|
Yes, this can be closed. Thanks!
…On Mon, Jun 3, 2024 at 3:03 PM Michael Kubacki ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .azurepipelines/Platform-Build-VS.yml
<#968 (comment)>
:
> @@ -28,8 +28,7 @@ jobs:
QemuQ35_DEBUG:
BuildPackage: QemuQ35Pkg
BuildFile: "Platforms/QemuQ35Pkg/PlatformBuild.py"
- BuildArch: IA32,X64
- BuildFlags: ""
+ BuildFlags: "-a IA32,X64"
@Javagedes <https://github.com/Javagedes>, can you please confirm this
thread can be closed?
—
Reply to this email directly, view it on GitHub
<#968 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2CHHPBSI3I77YBCU5FOJDZFTR2JAVCNFSM6AAAAABIXBIJFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOJUHE2DANZXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
kuqin12
approved these changes
Jun 3, 2024
kuqin12
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Passes the architecture for platform builds through the build flags.
For compatibility with the v10.0.0 Mu DevOps release: https://github.com/microsoft/mu_devops/releases/tag/v10.0.0
How This Was Tested
Integration Instructions