Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Memory Allocation HOB Entry for QEMU FDT Blob #876

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

TaylorBeebe
Copy link
Contributor

Description

The flattened device tree blob is placed in memory at the address specified by PcdDeviceTreeInitialBaseAddress. This PR creates a memory allocation HOB entry for the pages spanning the start and end of the FDT so it cannot be allocated during boot.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested by running SBSA and reviewing the memory allocation HOBs

Integration Instructions

N/A

Copy link
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, upstream they are dropping the FDT from SbsaQemu entirely. We could do the same in a future PR.

@TaylorBeebe TaylorBeebe enabled auto-merge (squash) March 19, 2024 17:11
@TaylorBeebe TaylorBeebe enabled auto-merge (squash) March 19, 2024 23:08
@TaylorBeebe TaylorBeebe merged commit 8bdc474 into microsoft:main Mar 19, 2024
28 checks passed
@TaylorBeebe TaylorBeebe deleted the fdt_blob_mem_alloc branch March 19, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:SBSA Specific to the SBSA platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants