Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PcdFixedDebugPrintErrorLevel in QemuSbsaPkg to Improve Boot Time #871

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

TaylorBeebe
Copy link
Contributor

Description

There's a large slowdown during GCD sync when the syncing logic debug dumps the GCD map thousands of times. I updated the syncing logic to skip the dump process if the GCD debug verbosity level is not set. Checking the verbosity is done via a call to DebugPrintLevelEnabled() in DebugLib which checks the fixed debug print PCD.

This PR sets the FixedAtBuild PCD to be the same as the PatchableInModule PCD so the map dump function is skipped.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested by booting SBSA and observing the improved boot time.

Integration Instructions

N/A

@TaylorBeebe TaylorBeebe changed the title Set PcdFixedDebugPrintErrorLevel in QemuSbsaPkg to Speed Up Boot Set PcdFixedDebugPrintErrorLevel in QemuSbsaPkg to Improve Boot Time Mar 4, 2024
@TaylorBeebe TaylorBeebe enabled auto-merge (squash) March 6, 2024 21:40
@TaylorBeebe TaylorBeebe merged commit be530da into microsoft:main Mar 6, 2024
28 checks passed
@TaylorBeebe TaylorBeebe deleted the sbsa_set_fixed_debug_pcd branch March 6, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants