Update basecore and supervisor submodules #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-d
approved these changes
Aug 28, 2024
apop5
approved these changes
Aug 28, 2024
|
My most recent change to ImageValidation plugin that this submodule update brought in fixed the fact that the plugin was skipping verification off all binaries on a CLANGPDB toolchain build; however it looks like the pefile pypi project is having issues with parsing one (or maybe all) of the pecoffs generated via CLANGPDB. I will investigate. |
makubacki
approved these changes
Aug 29, 2024
|
PR365 that went into pefile for release 2024.8.26 is the culprit. . It is failing to parse File "C:\Users\joeyvagedes\.virtualenvs\mu_tiano_platforms-hKhfHhJg\Lib\site-packages\pefile.py", line 4601, in parse_debug_directory
dbg_type.ExDllCharacteristics,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'ExDllCharacteristics'Edit: Issue posted erocarrera/pefile#421 |
This was referenced Aug 29, 2024
Javagedes
added a commit
to microsoft/mu_basecore
that referenced
this pull request
Aug 29, 2024
## Description This commit modifies the PE parsing functionality to only parse the headers of the image, rather than the entire image. This change is made to improve performance and also the probability of failing to parse the entire image. This comes after this commit (erocarrera/pefile#365) in pefile resulted in efi image parsing failures, breaking the build. This commit also wraps the parsing of the image in a try-except block to catch any exceptions that may be raised during parsing, to cleanly exit. See: microsoft/mu_tiano_platforms#1025 and erocarrera/pefile#421 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Validated pipelines build on mu_tiano_platforms ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update mu_basecore to top of release/202405 and supervisor repo to pair up with the updated override tags.
For details on how to complete to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
Tested on QEMU Q35 and booted to shell.
Integration Instructions
N/A