New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetupDataPkg/ConfApp: Fix incorrect type used in a GUID print #381

Merged

os-d merged 1 commit into microsoft:main from congmomo:main

Jul 16, 2024

Contributor

congmomo commented Jul 16, 2024 •

edited by makubacki

Loading

Description

The DEBUG message will throughout expectations, due to pass wrong type variable.
The %g parameter need to pass the GUID pointer not the variable itself. so chang TargetGuids[i] to &TargetGuids[i]

How This Was Tested

Test have been run on an Arm based simulator. No exception throughout after adding the &.

Integration Instructions

N/A


          %g needs to pass the GUID pointer not the variable. change TargetGuid…

9afcb5c

…s[i] to &TargetGuids[i]

github-actions bot added the impact:non-functional label

Contributor

apop5 commented Jul 16, 2024 •

edited

Loading

Can you please fill out the PR description?

And thank you for the PR.

apop5 approved these changes

View reviewed changes

apop5 requested review from os-d and kuqin12

July 16, 2024 17:00

makubacki changed the title ~~The DEBUG message will throughout expectations, due to pass wrong type variable.~~ SetupDataPkg/ConfApp: Fix incorrect type used in a GUID print

Member

makubacki commented Jul 16, 2024

I updated the PR title to what I think was intended.

os-d approved these changes

View reviewed changes

os-d enabled auto-merge (squash)

July 16, 2024 19:42

os-d merged commit fb0659d into microsoft:main

16 checks passed

ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms


          Bumps Features/CONFIG from 2.0.13 to 3.0.0

093dc60

Introduces 22 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/fb0659ddf4a1376951f94965897066c3c45a1147">fb0659</a> SetupDataPkg/ConfApp: Fix incorrect type used in a GUID print (<a href="https://github.com/microsoft/mu_feature_config/pull/381">#381</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/ab355596cfbb954f0409c8eb6064902a24c9953f">ab3555</a> pip: bump edk2-pytool-extensions from 0.27.9 to 0.27.10 (<a href="https://github.com/microsoft/mu_feature_config/pull/382">#382</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/7eb698bda947c51147c915af5a171c7723940ccb">7eb698</a> Removing script that would create windows executable from a python file. (<a href="https://github.com/microsoft/mu_feature_config/pull/380">#380</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/07d1b669353f00403ca11eb3ce39c61dd37ef3a4">07d1b6</a> pip: bump pytest from 8.2.2 to 8.3.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/384">#384</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/84061c7aa8e6f9e052cd6a0721f921eae0bb3e03">84061c</a> pip: bump pyopenssl from 24.1.0 to 24.2.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/383">#383</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/473977c0b06652214e6939d328896d35368e8384">473977</a> pip: bump regex from 2024.5.15 to 2024.7.24 (<a href="https://github.com/microsoft/mu_feature_config/pull/387">#387</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/a9ead46400658dc0cedd136ce2251eeeee6fe069">a9ead4</a> pip: bump xmlschema from 3.3.1 to 3.3.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/386">#386</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/e6856ba7a4424c55089debd983ece44cd037037b">e6856b</a> pip: bump pytest from 8.3.1 to 8.3.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/385">#385</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/2c08cd5c62bd9ffe20f8fe6d41b9d56d104484bd">2c08cd</a> pip: bump edk2-pytool-library from 0.21.8 to 0.21.9 (<a href="https://github.com/microsoft/mu_feature_config/pull/388">#388</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/c4ffcc4412785aba46f5498d79175f99c1fb4e40">c4ffcc</a> pip: bump flake8 from 7.1.0 to 7.1.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/391">#391</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/5552edcd3c09fae9d272372d5dc5f6ea4ec5d66f">5552ed</a> pip: bump antlr4-python3-runtime from 4.13.1 to 4.13.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/390">#390</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/377d9844a271eca2f050ad29411e97e30494e332">377d98</a> Switch to use edk2-pytool-library UefiVariableSupportLib. (<a href="https://github.com/microsoft/mu_feature_config/pull/362">#362</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/bd44e7931fa86b7923678804271f464cfd7c9126">bd44e7</a> pip: bump edk2-pytool-library from 0.21.9 to 0.21.10 (<a href="https://github.com/microsoft/mu_feature_config/pull/389">#389</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/7d4a54e701841709b317647e05c7a8ffe53c03cf">7d4a54</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_config/pull/392">#392</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/f7a1e789745eeefe9afe8b7bc4a4b12254becde5">f7a1e7</a> pip: bump edk2-pytool-extensions from 0.27.10 to 0.27.11 (<a href="https://github.com/microsoft/mu_feature_config/pull/393">#393</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/453b5f10d2114626af063fcc028ea21e1da26450">453b5f</a> New write_csv_detailed() to dump out data in expanded format (<a href="https://github.com/microsoft/mu_feature_config/pull/365">#365</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/837cef0c3d9551d8338945340c0fe201d8742845">837cef</a> pip: bump pefile from 2023.2.7 to 2024.8.26 (<a href="https://github.com/microsoft/mu_feature_config/pull/395">#395</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/45e7ee76295af096bbe4b1c493580800fc36e110">45e7ee</a> Update CI branches to release/202405 (<a href="https://github.com/microsoft/mu_feature_config/pull/394">#394</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/845fae589a8968ae43b417a2cf9b5dcaab4c0b5b">845fae</a> pip: bump edk2-pytool-extensions from 0.27.11 to 0.27.12 (<a href="https://github.com/microsoft/mu_feature_config/pull/396">#396</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/b0593c6c47fb62bb1f6477de0d98da5e31941e55">b0593c</a> Remove DFCI Python Scripts (<a href="https://github.com/microsoft/mu_feature_config/pull/397">#397</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/08512dfabc0fb1e9b8111e35c61b810de4c3bed4">08512d</a> pip: bump xmlschema from 3.3.2 to 3.4.0 (<a href="https://github.com/microsoft/mu_feature_config/pull/398">#398</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/4a6d3a356f87794ce332534853434ecbc6e5d84c">4a6d3a</a> pip: bump pytest from 8.3.2 to 8.3.3 (<a href="https://github.com/microsoft/mu_feature_config/pull/399">#399</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>

ProjectMuBot mentioned this pull request

Bump Features/CONFIG from 2.0.13 to 3.0.0 microsoft/mu_tiano_platforms#1035

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional