Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Kqlmagic with azure.data.kusto/azure.monitor SDK #510

Closed
ianhelle opened this issue Sep 15, 2022 · 1 comment · Fixed by #656
Closed

Replace Kqlmagic with azure.data.kusto/azure.monitor SDK #510

ianhelle opened this issue Sep 15, 2022 · 1 comment · Fixed by #656
Assignees
@ianhelle
Labels
enhancement New feature or request investigate Issue requires investigation
Milestone
Release 2.5.0

Comments

@ianhelle
Copy link
Contributor

ianhelle commented Sep 15, 2022 •
edited
Loading

Although we love Kqlmagic, it is very heavyweight for our needs:

  • it brings in a lot of dependencies (although not massive with Kqlmagiccustom)
  • There is a lot stuff going on that we have little control over (e.g. direct interactions with nb kernel, JS callouts)
  • Error handling is a little opaque due to the logging/warning wrapper that Kqlmagic uses.

It would be simpler in the long run to move the Sentinel data driver to use azure-monitor-query and the kusto driver to azure-data-kusto.
@ianhelle ianhelle added this to the Release 2.2.0 milestone Sep 19, 2022
@ianhelle ianhelle self-assigned this Sep 19, 2022
@ianhelle ianhelle modified the milestones: Release 2.2.0, Release 2.3.0 Nov 3, 2022
@ianhelle ianhelle mentioned this issue Nov 3, 2022
Closed
@ianhelle ianhelle added enhancement New feature or request investigate Issue requires investigation labels Feb 1, 2023
@ianhelle ianhelle modified the milestones: Release 2.3.0, Release 2.5.0 Feb 7, 2023
@ianhelle ianhelle linked a pull request May 16, 2023 that will close this issue
Sentinel and Kusto new providers #656
Merged
@ianhelle
Copy link
Contributor Author

Added in #656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianhelle ianhelle

Labels
enhancement New feature or request investigate Issue requires investigation
Projects
MSTICPy post-2.0 planning
Status: ✅ Done
Milestone
Release 2.5.0
Development

Successfully merging a pull request may close this issue.

Sentinel and Kusto new providers microsoft/msticpy
1 participant
@ianhelle