Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools are not installed in the container #8

Closed
LuisBosquez opened this issue Jan 6, 2017 · 5 comments
Closed

Tools are not installed in the container #8

LuisBosquez opened this issue Jan 6, 2017 · 5 comments

Comments

@LuisBosquez
Copy link
Contributor

There are multiple requests for having mssql-tools in the container to do data import and export and quick management of databases.

@bugbuilder
Copy link

If you don't add en_US.utf 8 as a dependency you will get this error:

terminate called after throwing an instance of 'std::runtime_error' what(): locale::facet::_S_create_c_locale name not valid

You should be add in the Dockerfile the next lines:
locale-gen en_US.utf8 && update-locale

@twright-msft
Copy link
Collaborator

Adding tools in the image increases the size by about 100 MB. Any concerns with that?

@metaskills
Copy link

None here!

@twright-msft
Copy link
Collaborator

We have added the mssql-tools package to the mssql-server-linux image in the CTP 1.4 release that was posted today.

I've updated my example that used to use the Dockerfile to install the tools to now just expect the tools to already be in the image.
https://github.com/twright-msft/mssql-node-docker-demo-app

For now people can use an approach like that to do things like create (#2) or attach (#4) DBs, create logins (#18,#49), or whatever else needs to be done (#11) at docker run time.

In the end, it only increased the image size by about 20-30 MB not the 100 MB we thought it would be at first.

Please give it a try and let us know what you think!

@metaskills
Copy link

Thanks! This simplified the setup we have to do for the TInyTDS and Rails SQL Server testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants