-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] ESM Module invalid code #2839
Comments
When this change is done, maybe the esm code could be used without a bundler |
Can you show some code that has such css imports? |
I've also created an issue at vscode: microsoft/vscode#139416 cause I don't know where it should be fixed. if your bundler should fix this, our if it should be fixed in vscode. (or both) |
I meant in the compiled js code. I'm aware of the css imports in the typescript source code, but I currently don't know how esbuild handles those. |
it looks like this:
|
Let's track in #886 |
Reproducible in vscode.dev or in VS Code Desktop?
Reproducible in the monaco editor playground?
Monaco Editor Playground Code
No response
Actual Behavior
The ESM Module Code of Monaco Editor contains css imports wich are non valid Javascript Code.
When they will be supported they need the following addition: "assert { type: 'css' };"
see also: https://web.dev/css-module-scripts/
Expected Behavior
css imports contain the assert
Additional Context
No response
The text was updated successfully, but these errors were encountered: