-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Enable "bottom-pinned" NavigationMenuItems in the NavigationView control #375
Comments
@jskollin - thank you for the great suggestion. Unfortunately, it will be a little while before we have the resources to be able to implement this proposal. |
I found some workaround, but it still working bad, because top navigation item still stays selected inside control: <muxc:NavigationView x:Name="NavigationView">
<muxc:NavigationView.MenuItems>
<muxc:NavigationViewItem>
<muxc:NavigationViewItem.Icon>
<SymbolIcon Symbol="Audio"/>
</muxc:NavigationViewItem.Icon>
Audio
</muxc:NavigationViewItem>
</muxc:NavigationView.MenuItems>
<muxc:NavigationView.PaneFooter>
<StackPanel>
<muxc:NavigationViewItem Tapped="NavigationViewItem_Tapped">
<muxc:NavigationViewItem.Icon>
<SymbolIcon Symbol="Add"/>
</muxc:NavigationViewItem.Icon>
Add
</muxc:NavigationViewItem>
</StackPanel>
</muxc:NavigationView.PaneFooter>
</muxc:NavigationView> private void NavigationViewItem_Tapped(object sender, TappedRoutedEventArgs e)
{
NavigationView.SelectedItem = sender;
} |
Bottom placement for the horizontal navigation view (as with the top placement) makes a lot of sense. Same with explicit right hand side placement of the vertical orientation navigation view. (not just in RtL scenarios) This should also extend to the tab control to give maximum flexibility with navigation app layouts |
I guess you are asking for different feature and it's better to create new proposal |
Yes, I misunderstood the ask. I blame responding via mobile :P |
How many items does anybody need at the bottom? |
@ad1Dima, #1488 is an interesting idea that many apps are likely to find helpful but probably doesn't solve 100% of app scenarios. Keeping both proposals makes sense to me. |
that's true. We need both. My question was about: should it be list of bottom items, or adding one or two item to the bottom will be fine? |
Copy here from my PR: Usage example and screenshots:<muxc:NavigationView x:Name="NavigationView" ItemInvoked="NavigationView_ItemInvoked" IsSettingsVisible="{x:Bind SettingsCheckbox.IsChecked.Value, Mode=OneWay}">
<muxc:NavigationView.MenuItems>
<muxc:NavigationViewItem Icon="Audio" Content="Audio"/>
<muxc:NavigationViewItem Icon="Video" Content="Video"/>
<muxc:NavigationViewItem Icon="View" Content="View"/>
</muxc:NavigationView.MenuItems>
<muxc:NavigationView.FooterMenuItems>
<muxc:NavigationViewItem Icon="Account" Content="Account" />
</muxc:NavigationView.FooterMenuItems>
<muxc:NavigationView.PaneFooter>
<Grid Background="Red">
<TextBlock Text="PaneFooter"/>
</Grid>
</muxc:NavigationView.PaneFooter>
<Grid>
<StackPanel Margin="12">
<Button Click="Button_Click">
Left/Top switch
</Button>
<CheckBox x:Name="SettingsCheckbox" Content="IsSettingsVisible" IsChecked="True"/>
<TextBlock Text="{x:Bind ((muxc:NavigationViewItem)NavigationView.SelectedItem).Content.ToString(), Mode=OneWay}"/>
</StackPanel>
</Grid>
</muxc:NavigationView>
|
Right.. it sits in the back burner until we have docs/samples. |
Hey @ad1Dima, now that the implementation for this feature is complete (a huge thank you to you!), have you tried out the feature and added it to an app yet? If so it would be great to hear more about your scenario and any more feedback you might have. Let me know! 😊 |
I used it for almost year since my first PR ) hope #3101 will be on the way soon. It'll keep my code cleaner |
@ad1Dima Awesome, thanks so much! Glad it's been working for you. |
Proposal: Enable "bottom-pinned" NavigationMenuItems in the NavigationView control
Summary
There are 3 issues that prevent users from easily being able to add new items to the Footer of the NavigationView (elaborated on in the rationale section):
Rationale
Similar to the built-in Settings NavigationMenuItem, users may want to add additional pages to the Footer of the NavigationView. There are several issues that come about with this:
Functional Requirements
Important Notes
Open Questions
The text was updated successfully, but these errors were encountered: