Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrator does not read out the NavigationView button after activating close/open NavigationView button in WPF Xaml Islands #3494

Closed
arjunbalgovind opened this issue Oct 26, 2020 · 3 comments
Labels
accessibility Narrator, keyboarding, UIA, etc area-Accessibility area-Islands Xaml Islands feature needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) no-issue-activity

Comments

@arjunbalgovind
Copy link

arjunbalgovind commented Oct 26, 2020

Describe the bug

If the user has tab focus on the Open/Close NavigationView button, the Narrator will initially read out "Close Navigation..." and after pressing Enter on it, the NavigationView closes but it does not read out the new name "Open Navigation...". On all examples of NavigationView on the Xaml Controls Gallery app, this behavior does not happen. The button is read out by the narrator whenever it is activated.

Steps to reproduce the bug

Steps to reproduce the behavior:
It can be reproduced on the WPF Xaml Islands Sample by modifying this to Left:
https://github.com/microsoft/Xaml-Islands-Samples/blob/4889c827866adfc9ef95a675384cebe998cc28ce/Samples/Managed/UWPApplication/MainPage.xaml#L22

  1. Go to Open/Close NavigationView button with Narrator switched on
  2. Press Enter to activate the button

Expected behavior

Narrator should read out the name of the button before and after pressing Enter to notify the user that an event has taken place.

Screenshots

The bug can be reproduced on PowerToys (which uses a WPF Xaml Islands). The issue microsoft/PowerToys#7024 has a video of the repro.
Version Info

NuGet package version:

Microsoft.UI.Xaml 2.5.0-prerelease.200923002

Windows app type:

UWP Win32
Yes

WPF Xaml Island

Windows 10 version Saw the problem?
Insider Build (xxxxx)
May 2020 Update (19041) Yes
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context

The bug can be reproduced on PowerToys Settings (which uses a WPF Xaml Islands). The tracking issue is microsoft/PowerToys#7024

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 26, 2020
@ranjeshj ranjeshj added area-Islands Xaml Islands feature team-Controls Issue for the Controls team needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) team-Reach Issue for the Reach team and removed team-Controls Issue for the Controls team labels Oct 27, 2020
@ranjeshj
Copy link
Contributor

This seems to be specific to being inside an island. I can see that Xaml Controls Gallery works as expected.

@Austin-Lamb Austin-Lamb added team-Framework accessibility Narrator, keyboarding, UIA, etc area-Accessibility and removed team-Reach Issue for the Reach team labels Jan 6, 2021
@chrisglein
Copy link
Member

Looks like Ranjesh has confirmed that this doesn't repro outside of an islands context, so it doesn't seem to be an issue with that control. Not sure how this is influenced by being in an island. @Austin-Lamb what's your take on what would be different here?

@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Narrator, keyboarding, UIA, etc area-Accessibility area-Islands Xaml Islands feature needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) no-issue-activity
Projects
None yet
Development

No branches or pull requests

4 participants