You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The 2.4 release broke the ItemInvoked API contract by returning the realized UI Element from the new underlying ItemsRepeater instead of the Item from the underlying MenuItemsSource collection.
@ojhad@ranjeshj is this fixed in the new 2.5 prerelease package?
This is a regression and breaking change to anyone using this event on NavigationView updating to 2.4.x, so will it be patched in the 2.4 line as well?
Describe the bug
The 2.4 release broke the
ItemInvoked
API contract by returning the realized UI Element from the new underlying ItemsRepeater instead of theItem
from the underlyingMenuItemsSource
collection.Steps to reproduce the bug
Sample Code
Code Behind
Steps to reproduce the behavior:
See the 2.3.200213001 branch on the same repo. You can switch to that which has the previous NuGet package setup to see the difference in behavior.
Actual behavior
NavigationViewItemInvokedEventArgs.ItemInvoked
is a UIElement of the realized data template.Expected behavior
Should return the underlying Item in the args from the
MenuItemsSource
(as it did before in 2.3).Screenshots
Item Invoked for Item (Controls):
2.3.200213001
2.4.2
Note: Here we're not getting our item as we'd expect!
Item Invoked for Settings (this looks the same and seems fine, but adding for completeness)
2.3.200213001
2.4.2
Version Info
NuGet package version: Microsoft.UI.Xaml 2.4.2
Additional context
The text was updated successfully, but these errors were encountered: