Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression in PointerOver when no MenuItems are defined in NavigationView #2409

Closed
JuanMejiaVelez opened this issue May 7, 2020 · 3 comments
Labels
area-NavigationView NavView control no-issue-activity team-Controls Issue for the Controls team

Comments

@JuanMejiaVelez
Copy link
Member

JuanMejiaVelez commented May 7, 2020

Describe the bug
When no MenuItems are defined in a NavigationView the Settings (and PaneFooter if using a NavigationViewItem) do not get the PointerOver background extended to the full width of the control.

Steps to reproduce the bug

  1. Add a NavigationView control
  2. Do not add any MenuItems to the control only the NavigationView tag
  3. Run the app

Expected behavior
When hovering over Settings entry at the bottom of the NavigationView, the PointerOver state shows the background of the Settings item to expand the whole width of the Navigation pane.

Screenshots
image

Version Info
2.4.0-prerelease.200506001 on Windows build 19041.21 running on Desktop

NuGet package version:
2.4.0-prerelease.200506001

Windows 10 version Saw the problem?
Insider Build (xxxxx) Yes
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Mobile
Xbox
Surface Hub
IoT

Additional context

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label May 7, 2020
@ranjeshj ranjeshj added area-NavigationView NavView control team-Controls Issue for the Controls team needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) and removed needs-triage Issue needs to be triaged by the area owners labels May 7, 2020
@ranjeshj
Copy link
Contributor

ranjeshj commented May 7, 2020

When there are no Items it looks like the PaneContentGrid sizes to the footer items and aligns to the left instead of stretching to take the entire pane width.

@ojhad Should this be Stretch instead of Left ?

HorizontalAlignment="Left"

@ojhad
Copy link
Contributor

ojhad commented May 8, 2020

When there are no Items it looks like the PaneContentGrid sizes to the footer items and aligns to the left instead of stretching to take the entire pane width.

@ojhad Should this be Stretch instead of Left ?

HorizontalAlignment="Left"

If I remember correctly, changing that property to Stretch will break visuals in the control when the pane is in compact mode. This is due to PaneContentGrid still being full width even when in compact mode. Something to double check but I think the problem may lie somewhere else.

@StephenLPeters StephenLPeters removed the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Dec 5, 2020
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control no-issue-activity team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

5 participants