Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heinous speed issues with ALEAgentHost #252

Closed
DaveyBiggers opened this issue Aug 3, 2016 · 1 comment
Closed

Heinous speed issues with ALEAgentHost #252

DaveyBiggers opened this issue Aug 3, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@DaveyBiggers
Copy link
Member

Rough timing tests (on my sluggish VM):
ALEAgentHost.sendCommand takes roughly 10-15ms.
Of that:
ALEInterface::act is taking about 0.3ms
The frame scaling/copying is taking (on average) around 0.3ms

The remaining 95% of the time appears to be spent in the reward code - largely, I suspect, in serialising/deserialising the reward XML message.

Needless to say, it should be possible to speed this up.

@DaveyBiggers DaveyBiggers added the P1 label Aug 3, 2016
@DaveyBiggers DaveyBiggers self-assigned this Aug 3, 2016
@DaveyBiggers DaveyBiggers added this to the Dolphin milestone Aug 3, 2016
@DaveyBiggers
Copy link
Member Author

This constructor is the culprit:
TimestampedReward::TimestampedReward(boost::posix_time::ptime timestamp,std::string xml_string)
It is taking around 10ms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant