Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for vendor specific mime types in serialization/deserialization in ruby #1661

Closed
Tracked by #1049
baywet opened this issue Jun 27, 2022 · 0 comments · Fixed by #2103
Closed
Tracked by #1049

add support for vendor specific mime types in serialization/deserialization in ruby #1661

baywet opened this issue Jun 27, 2022 · 0 comments · Fixed by #2103
Assignees
Labels
enhancement New feature or request fixed Ruby
Milestone

Comments

@baywet
Copy link
Member

baywet commented Jun 27, 2022

more details at #1461

The factories registries for parse node and serialization need to to be updated to perform a staggered lookup.

  1. The headers can technically contain multiple content mime types separated by ;, so we need to split and trim first.
  2. The mime type can be vendor specific application/vendor.product+json, we should try an exact match and return it if we find a factory.
  3. If we don't, we should remove the vendor part vendor.product and lookup the registry with a non-vendor specific entry, return the factory we find if any.
  4. If we haven't found anything, throw an error (like we do today)
@baywet baywet added enhancement New feature or request Ruby labels Jun 27, 2022
@baywet baywet changed the title add support for vendor specific mime types in serialization/deserialization add support for vendor specific mime types in serialization/deserialization in ruby Jun 27, 2022
@baywet baywet assigned osose-e and unassigned osose-e Sep 2, 2022
@baywet baywet added this to the Kiota post-GA milestone Dec 6, 2022
@baywet baywet self-assigned this Dec 22, 2022
@baywet baywet linked a pull request Dec 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Ruby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants