Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide better support for the underlying shells #79

Closed
8 of 10 tasks
cpendery opened this issue Nov 15, 2023 · 2 comments
Closed
8 of 10 tasks

feat: provide better support for the underlying shells #79

cpendery opened this issue Nov 15, 2023 · 2 comments
Assignees
Milestone

Comments

@cpendery
Copy link
Member

cpendery commented Nov 15, 2023

As mentioned in a number of issues (#5, #9, #10, #11, #19, and more) inshellisense's current support for the underlying shell is incomplete and needs to be improved. Currently inshellisense merely passes each command to a new pty session with the same shell as the user's current shell or the selected shell via the -s/--shell flag. This will be change moving forward to a more robust solution that will support complex shell behaviors with aliases, custom prompts, and more. As a result, PRs adding new functionality to the ink implementation of the root command will not be merged as that code will be removed in the rewrite.

More updates will be added to this issue when available.

@theKnightsOfRohan
Copy link

implement the ui layer which shows the suggestions with the shell's output

By this, do you mean that inshellisense will not start a new pseudo shell session, and will instead add the suggestions onto the existing shell UI, similar to other command-line tools?

@cpendery
Copy link
Member Author

implement the ui layer which shows the suggestions with the shell's output

By this, do you mean that inshellisense will not start a new pseudo shell session, and will instead add the suggestions onto the existing shell UI, similar to other command-line tools?

It will start a long running psuedo terminal which it will then add suggestions too, so while a new shell session will be started, that session will be a fully functional shell, similar to starting a new terminal session in VSCode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants