Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Migrate createSlideStyles to Fade motion component #33422

Open
robertpenner opened this issue Dec 6, 2024 · 1 comment · May be fixed by #33424
Open

[Popover] Migrate createSlideStyles to Fade motion component #33422

robertpenner opened this issue Dec 6, 2024 · 1 comment · May be fixed by #33424

Comments

@robertpenner
Copy link
Collaborator

createSlideStyles generates CSS keyframes that is used in Popover, MenuPopover, and about a dozen components that import them:

export function createSlideStyles(mainAxis: number): GriffelStyle {
  const fadeIn = {
    from: {
      opacity: 0,
    },
    to: {
      opacity: 1,
    },
  };
  // slide keyframes
  ...

Move the opacity transition to a Fade instance.

@robertpenner
Copy link
Collaborator Author

  • Discussion on refactor(Popover): migrate opacity transition to Fade component #33424 indicates that we should migrate the fade and slide together, rather than the fade separately, to avoid maintenance issues.
  • The slide migration is high effort and high risk. The code has connections between JavaScript and DOM attributes that are tricky to read from motion components; there appears to a race condition to mitigate.
  • Also, the slide uses an integration with a third-party library Floating UI.
  • Fluent Eng flagged potential for regressions in Teams usage if we're not careful.
  • Fluent Eng would like a motion slot created, which adds to the level of effort.

Thus, returning this to the backlog pending re-evaluation of priorities and strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants