From 27dfeadc8f7f65b6217d93b3332c722324d033e4 Mon Sep 17 00:00:00 2001 From: Martin Hochel Date: Wed, 15 Feb 2023 13:54:18 +0100 Subject: [PATCH] fix(web-components): dont ship non production assets to npm registry (#26854) * fix(web-components): dont ship non production assets to npm registry * generate change file --- ...-c9bafa19-7bba-4e91-a34b-ef812e450e99.json | 7 ++++++ packages/web-components/.npmignore | 23 ++++++++++++------- packages/web-components/package.json | 10 +++----- .../web-components/src/badge/badge.stories.ts | 2 +- .../counter-badge/counter-badge.stories.ts | 2 +- .../src/{helpers.ts => helpers.stories.ts} | 0 .../src/progress-bar/progress-bar.stories.ts | 2 +- .../src/spinner/spinner.stories.ts | 2 +- .../web-components/src/text/text.stories.ts | 2 +- 9 files changed, 30 insertions(+), 20 deletions(-) create mode 100644 change/@fluentui-web-components-c9bafa19-7bba-4e91-a34b-ef812e450e99.json rename packages/web-components/src/{helpers.ts => helpers.stories.ts} (100%) diff --git a/change/@fluentui-web-components-c9bafa19-7bba-4e91-a34b-ef812e450e99.json b/change/@fluentui-web-components-c9bafa19-7bba-4e91-a34b-ef812e450e99.json new file mode 100644 index 00000000000000..6a39c8a756c5d1 --- /dev/null +++ b/change/@fluentui-web-components-c9bafa19-7bba-4e91-a34b-ef812e450e99.json @@ -0,0 +1,7 @@ +{ + "type": "prerelease", + "comment": "fix(web-components): dont ship non production assets to npm registry", + "packageName": "@fluentui/web-components", + "email": "martinhochel@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/packages/web-components/.npmignore b/packages/web-components/.npmignore index 4283a6309c2c18..f5729e7a6aa564 100644 --- a/packages/web-components/.npmignore +++ b/packages/web-components/.npmignore @@ -1,34 +1,41 @@ +.vscode/ + # Tests *.spec.* *.test.* coverage/ +__fixtures__ +__mocks__ +__tests__ # images images/ # Source files src/ - scripts/ # config files .eslintignore .eslintrc.js +.eslintrc.json .prettierignore -.storybook tsconfig.json -tsconfig.lib.json -tsconfig.spec.json -tsconfig.build.json +tsconfig.*.json rollup.config.json +rollup.config.js karma.conf.cjs api-extractor.json .mocharc.json -# Storybook static site -dist/storybook-static/ +# Storybook +.storybook +*.stories.* public/ +dist/storybook-static/ # cache .rollupcache -temp +temp/ +etc/ +CHANGELOG.json diff --git a/packages/web-components/package.json b/packages/web-components/package.json index 9042053d139d6f..18d87dfafbf8db 100644 --- a/packages/web-components/package.json +++ b/packages/web-components/package.json @@ -50,12 +50,8 @@ "api-extractor": "api-extractor", "compile": "node ./scripts/compile", "clean": "node ./scripts/clean dist", - "doc": "api-extractor run --local", - "doc:ci": "yarn doc", - "build": "yarn compile && rollup -c && yarn doc", - "dev": "tsc -p ./tsconfig.json -w", - "tdd": "yarn dev & yarn test-chrome:watch", - "prepare": "yarn clean && yarn build", + "generate-api": "api-extractor run --local", + "build": "yarn compile && rollup -c && yarn generate-api", "lint": "eslint . --ext .ts", "lint:fix": "eslint . --ext .ts --fix", "format": "prettier -w 'src/**/(*.ts|*.html)' --ignore-path ../../.prettierignore", @@ -64,7 +60,7 @@ "start": "yarn start-storybook -p 6006 --docs --no-manager-cache", "start-storybook": "node node_modules/@storybook/html/bin/index", "build-storybook": "node node_modules/@storybook/html/bin/build -o ./dist/storybook --docs", - "test": "yarn doc:ci && yarn test-chrome:verbose", + "test": "yarn test-chrome:verbose", "test-node": "mocha --reporter min --exit dist/esm/__test__/setup-node.js './dist/esm/**/*.spec.js'", "test-node:verbose": "mocha --reporter spec --exit dist/esm/__test__/setup-node.js './dist/esm/**/*.spec.js'", "test-chrome": "karma start karma.conf.cjs --browsers=ChromeHeadlessOpt --single-run --coverage", diff --git a/packages/web-components/src/badge/badge.stories.ts b/packages/web-components/src/badge/badge.stories.ts index 4016ea4a14272a..e5a74e063f6339 100644 --- a/packages/web-components/src/badge/badge.stories.ts +++ b/packages/web-components/src/badge/badge.stories.ts @@ -1,6 +1,6 @@ import { html, when } from '@microsoft/fast-element'; import type { Args, Meta } from '@storybook/html'; -import { renderComponent } from '../helpers.js'; +import { renderComponent } from '../helpers.stories.js'; import type { Badge as FluentBadge } from './badge.js'; import { BadgeAppearance, BadgeColor, BadgeShape, BadgeSize } from './badge.options.js'; import './define.js'; diff --git a/packages/web-components/src/counter-badge/counter-badge.stories.ts b/packages/web-components/src/counter-badge/counter-badge.stories.ts index e57d6f8097a16d..89f904621804b4 100644 --- a/packages/web-components/src/counter-badge/counter-badge.stories.ts +++ b/packages/web-components/src/counter-badge/counter-badge.stories.ts @@ -1,6 +1,6 @@ import { html } from '@microsoft/fast-element'; import type { Args, Meta } from '@storybook/html'; -import { renderComponent } from '../helpers.js'; +import { renderComponent } from '../helpers.stories.js'; import type { CounterBadge as FluentCounterBadge } from './counter-badge.js'; import { CounterBadgeAppearance, diff --git a/packages/web-components/src/helpers.ts b/packages/web-components/src/helpers.stories.ts similarity index 100% rename from packages/web-components/src/helpers.ts rename to packages/web-components/src/helpers.stories.ts diff --git a/packages/web-components/src/progress-bar/progress-bar.stories.ts b/packages/web-components/src/progress-bar/progress-bar.stories.ts index 5977e4f4b382ef..5d609ff780d73e 100644 --- a/packages/web-components/src/progress-bar/progress-bar.stories.ts +++ b/packages/web-components/src/progress-bar/progress-bar.stories.ts @@ -1,6 +1,6 @@ import { html } from '@microsoft/fast-element'; import type { Args, Meta } from '@storybook/html'; -import { renderComponent } from '../helpers.js'; +import { renderComponent } from '../helpers.stories.js'; import type { ProgressBar as FluentProgressBar } from './progress-bar.js'; import { ProgressBarShape, ProgressBarThickness, ProgressBarValidationState } from './progress-bar.options.js'; import './define.js'; diff --git a/packages/web-components/src/spinner/spinner.stories.ts b/packages/web-components/src/spinner/spinner.stories.ts index ee05e791565e71..e9f607798711ba 100644 --- a/packages/web-components/src/spinner/spinner.stories.ts +++ b/packages/web-components/src/spinner/spinner.stories.ts @@ -1,6 +1,6 @@ import { html } from '@microsoft/fast-element'; import type { Args, Meta } from '@storybook/html'; -import { renderComponent } from '../helpers.js'; +import { renderComponent } from '../helpers.stories.js'; import { SpinnerAppearance, SpinnerSize } from './spinner.options.js'; import './define.js'; diff --git a/packages/web-components/src/text/text.stories.ts b/packages/web-components/src/text/text.stories.ts index 45bea65c603585..9149311851f615 100644 --- a/packages/web-components/src/text/text.stories.ts +++ b/packages/web-components/src/text/text.stories.ts @@ -1,6 +1,6 @@ import { html } from '@microsoft/fast-element'; import type { Args, Meta } from '@storybook/html'; -import { renderComponent } from '../helpers.js'; +import { renderComponent } from '../helpers.stories.js'; import type { Text as FluentText } from './text.js'; import './define.js'; import { TextAlign, TextFont, TextSize, TextWeight } from './text.options.js';