Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application installation screen should be smarter about already installed apps #717

Closed
localden opened this issue May 23, 2023 · 9 comments
Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-Install Related to app installation in machine config flow Issue-Feature New feature or request Priority-2 Resolution-Fix-Available Available in a release

Comments

@localden
Copy link
Member

localden commented May 23, 2023

Notice that I have Python already installed, at the exactly the same version.

The same view also suggests I install Visual Studio 2022 Community, when I already have the Enterprise edition installed.

image

It did detect VS Code, though.

image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label May 23, 2023
@krschau krschau added the Area-Machine-Config Related to the machine configuration feature label May 23, 2023
@AmelBawa-msft AmelBawa-msft added Area-Machine-Config-Install Related to app installation in machine config flow and removed Needs-Triage New issue that the core contributors need to triage labels May 26, 2023
@AmelBawa-msft AmelBawa-msft added Issue-Feature New feature or request Needs-Triage New issue that the core contributors need to triage labels Jun 2, 2023
@denelon denelon removed the Needs-Triage New issue that the core contributors need to triage label Jun 5, 2023
@denelon
Copy link
Contributor

denelon commented Jun 5, 2023

@localden does winget list python show the same version installed and "winget" in the source column.

I'm trying to determine if this is a bug in WinGet or something with how the package is installed or reported in the registry for Windows Apps & Features.

@denelon denelon added the Needs-Author-Feedback Original author needs to come back and respond to a comment label Jun 5, 2023
@localden
Copy link
Member Author

localden commented Jun 7, 2023

@denelon
image

Python 3.11 that I have installed on my box is not from WinGet.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage New issue that the core contributors need to triage Needs-Team-Response and removed Needs-Author-Feedback Original author needs to come back and respond to a comment labels Jun 7, 2023
@denelon
Copy link
Contributor

denelon commented Jun 7, 2023

How was it installed?
It looks like it might have something to do with the matching logic in WinGet, or the source of the original install.

@localden
Copy link
Member Author

localden commented Jun 7, 2023

Directly from the Python website.

@denelon
Copy link
Contributor

denelon commented Jun 8, 2023

Can you share the URL so we can test?

@localden
Copy link
Member Author

localden commented Jun 9, 2023

https://www.python.org/ftp/python/3.11.4/python-3.11.4-amd64.exe

@AmelBawa-msft AmelBawa-msft added Priority-2 and removed Needs-Triage New issue that the core contributors need to triage labels Jun 9, 2023
@denelon
Copy link
Contributor

denelon commented Jun 9, 2023

I linked the Issue over at the WinGet community repository. It might be a simple case, of not having the latest version of Python.

@denelon
Copy link
Contributor

denelon commented Jun 9, 2023

I just noticed in the screenshot it looks like it's reporting 3.11.3 and the URL provided is 3.11.4. One of the WinGet community repository members already has a PR for the new version in the linked issue. Once that publishes, we can test and see if that resolves the issue, or if we need to dig in a bit further to see why we're not able to correlate based on the metadata in the registry keys behind Windows Apps & Features.

@cinnamon-msft
Copy link
Contributor

I think this may be resolved. I'm not seeing apps I already have installed appearing in the popular apps list. I'm going to close as fixed, but let us know if you're still seeing this!

@cinnamon-msft cinnamon-msft added the Resolution-Fix-Available Available in a release label Aug 20, 2024
@krschau krschau added this to the Dev Home v0.17 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-Install Related to app installation in machine config flow Issue-Feature New feature or request Priority-2 Resolution-Fix-Available Available in a release
Projects
None yet
Development

No branches or pull requests

6 participants