Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_gevent is failing #1375

Closed
int19h opened this issue Aug 30, 2023 · 6 comments
Closed

test_gevent is failing #1375

int19h opened this issue Aug 30, 2023 · 6 comments
Assignees
Labels
test issue Test failures and other issues with test runs and CI.

Comments

@int19h
Copy link
Contributor

int19h commented Aug 30, 2023

Due to warning for deprecated usage of pkg_resources in more recent versions of setuptools.

@int19h int19h added the test issue Test failures and other issues with test runs and CI. label Aug 30, 2023
@int19h int19h self-assigned this Aug 30, 2023
@int19h
Copy link
Contributor Author

int19h commented Sep 6, 2023

Fixed by #1374

@kira-bruneau
Copy link
Contributor

Hi @int19h! It looks like we're still having this problem in python versions older than 3.7 in nixpkgs. Was just wondering if you had any insight for why it'd still be failing: NixOS/nixpkgs#255379 (review).

Adding importlib-metadata as a test dependency doesn't seem to make a difference.

@int19h
Copy link
Contributor Author

int19h commented Sep 18, 2023

importlib-metadata is really only used for logging. The problem with gevent is a different issue - it's due to an incompatibility between gevent and newer versions of setuptools. You have to use setuptools<66 to fix it.

Also note that any version of debugpy >=1.6.0 doesn't support versions of Python older than 3.7, and debugpy>=1.8.0 requires python>=3.8.

@kira-bruneau
Copy link
Contributor

Oh yep!! We've marked python 3.8 as the minimum compatible python version in the 1.8.0 update.

We were just seeing this deprecation warning in newer versions of python too. From what I can tell, it looks like the setuptools<66 workaround was only being used for python 3.7?

@int19h
Copy link
Contributor Author

int19h commented Sep 18, 2023

Yep, that's the only version for which it showed up in our CI runs. Although I believe the problem there wasn't actually with Python itself, but rather with setuptools version that is bundled with it; if it's too old, it ends up being updated to the most recent version as a transitive dependency of something else (IIRC, tox itself), causing the problem.

@kira-bruneau
Copy link
Contributor

kira-bruneau commented Sep 18, 2023

Oh ok that makes sense! In nixpkgs, we package setuptools ourselves, so it would generally always be the latest version (even with older python versions). Thanks!! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test issue Test failures and other issues with test runs and CI.
Projects
None yet
Development

No branches or pull requests

2 participants