Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - BUG] Impact Analysis Results Incorrect #7033

Closed
1 task done
NattyG19 opened this issue Nov 7, 2023 · 8 comments
Closed
1 task done

[CoE Starter Kit - BUG] Impact Analysis Results Incorrect #7033

NattyG19 opened this issue Nov 7, 2023 · 8 comments
Assignees
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues

Comments

@NattyG19
Copy link

NattyG19 commented Nov 7, 2023

Does this bug already exist in our backlog?

  • I have checked and confirm this is a new bug.

Describe the issue

When running the DLP Analysis app, applying a tenant level DLP policy using Exclude Certain Environments scope, the impact analysis results come back with 0 apps and 0 flows impacts. 0 apps and 0 flows analysed.

I have purposefully blocked a common connector to test this functionality and it still is not showing the correct results.

When I choose Add to Multiple Environments as the scope, the impact analysis results in 67 impacted flows. However, the number of apps and flows analysed does not match what is recorded in the PPAC as the totals in those environments added.

Seems there is an issue with the scope options and all assets being picked up and analysed.

Expected Behavior

Impact analysis should show and accurate list impacted apps and flows and an accurate count of apps and flows analysed for the environment parameters selected.

What solution are you experiencing the issue with?

Core

What solution version are you using?

4.16

What app or flow are you having the issue with?

DLP Impact Analysis

What method are you using to get inventory and telemetry?

Cloud flows

Steps To Reproduce

  1. Select an Applied Policy to test
  2. Scope = Exclude Certain environments
  3. Add excluded enviros to policy
  4. Review impact results showing no impacts and no apps or flows analysed.

Anything else?

DLP Impact Analysis Incorrect Results

AB#710

@NattyG19 NattyG19 added bug Something isn't working coe-starter-kit CoE Starter Kit issues labels Nov 7, 2023
@manuelap-msft
Copy link
Contributor

The DLP Impact Analysis tool works of the inventory stored in the CoE kit Dataverse tables which is populated by the sync cloud flows. Let's first verify that you have a complete inventory:

Can you check the Power Platform Admin View and do you see the full intenvory of environments, apps and flows there if you do a spot check?
Can you open the CoE Admin Command Center and the CoE flows page there to see if there's any issues with the flows responsible for inventory?

@NattyG19
Copy link
Author

hi, I've checked the PP Admin View and the full list of environments are there, along with expected numbers of apps and flows which I've compared to the CoE Power BI report.

I've just run the DLP Analysis app again and also used the previous DLP Editor V2 app (which we imported to the CoE Enviro) and both are not picking up on any non-compliance even though our end users were impacted when policies were Assigned to environments which was not meant to happen!

Also double checked all the sync flows are working as expected.

The Command Center app is showing all sync flows are turned off when in fact they are turned on which I checked in the solution itself. That also seems to be an issue now.

Command Center App - Flows off when On

@NattyG19
Copy link
Author

I have since had one of my team look at the DLP Analysis app and we have found the problem

Issue: the DLP editor collects the display name of the connectors that are blocked/non-business, e.g "Gmail", "SharePoint", and then compares it to the asset record's "App Connections" or "Flow Connections" field (text field).

This worked until the latest CoE version update, where the App/Flow Connections fields were changed to record the idname of the connectors, so they are "shared_gmail" and "shared_sharepointonline" now. Therefore nothing matches!!

image

@Jenefer-Monroe
Copy link
Collaborator

I just noticed that the on/off on that screen isnt working today too. Will post thank you

@Jenefer-Monroe
Copy link
Collaborator

I am not reproing this. We did change what is stored in apps/flows to be the id instead of the string quite a while ago, and it looks like you go that change. Will have to have the app owner take a look.

@Jenefer-Monroe
Copy link
Collaborator

@v-bjaiswal please see if you can repro

@Jenefer-Monroe
Copy link
Collaborator

Found a repro in which if you select "all environments" it does not get the impacted apps / flows.

@Jenefer-Monroe Jenefer-Monroe moved this to Todo ✏️ in CoE Starter Kit Nov 26, 2023
@Jenefer-Monroe Jenefer-Monroe removed their assignment Nov 26, 2023
@ramontebar
Copy link

Hi, we are having the same issue as described by @NattyG19 in our deployment when using "Exclude certain environments". Running latest Nov version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues
Projects
Status: Done
Development

No branches or pull requests

7 participants