Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when building android project React Native 0.43-rc1 #408

Closed
RichardLindhout opened this issue Mar 6, 2017 · 7 comments
Closed

Errors when building android project React Native 0.43-rc1 #408

RichardLindhout opened this issue Mar 6, 2017 · 7 comments
Assignees

Comments

@RichardLindhout
Copy link

See these pull requests
facebook/react-native#12329
facebook/react-native#12396

In the CodePushNativeModule.java we need to import
import com.facebook.react.modules.core.ReactChoreographer;

And there are errors in

//                            getReactApplicationContext().runOnUiQueueThread(new Runnable() {
//                                @Override
//                                public void run() {
//                                    ReactChoreographer.getInstance().postFrameCallback(ReactChoreographer.CallbackType.TIMERS_EVENTS, new Choreographer.FrameCallback() {
//                                        @Override
//                                        public void doFrame(long frameTimeNanos) {
//                                            if (!latestDownloadProgress.isCompleted()) {
//                                                dispatchDownloadProgressEvent();
//                                            }
//
//                                            hasScheduledNextFrame = false;
//                                        }
//                                    });
//                                }
//                            });
@sergey-akhalkov
Copy link
Contributor

sergey-akhalkov commented Mar 6, 2017

@RichardLindhout, thanks for reporting the issue!
Here is the PR fixing it: microsoft/react-native-code-push#735, hoping the PR will be merged soon.

@RichardLindhout
Copy link
Author

Ah thank you, did not see that pull request!

@aslak-dirdal
Copy link

When will this be fixed?

@richardhuaaa
Copy link
Contributor

richardhuaaa commented Mar 22, 2017

@aslakagens, the fix should be merged tomorrow or the day after.

@sergey-akhalkov
Copy link
Contributor

sergey-akhalkov commented Mar 23, 2017

Closing this due to microsoft/react-native-code-push#735 has been merged. Please feel free to reopen if needed.

@richardhuaaa
Copy link
Contributor

We will publish this on npm the same day that RN 0.43 exits RC.

@sergey-akhalkov
Copy link
Contributor

We've released new version of React Native Module for CodePush: react-native-code-push@2.0.1-beta (it's available via npm), please let me know if you see any issues or have any questions.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants