Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code owners on repos #6401

Closed
11 of 13 tasks
gabog opened this issue Nov 10, 2021 · 0 comments
Closed
11 of 13 tasks

Update code owners on repos #6401

gabog opened this issue Nov 10, 2021 · 0 comments
Assignees
@gabog
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete team-agility An issue targeted to reduce friction to the SDK's development process.
Milestone
R2022.1

Comments

@gabog
Copy link
Contributor

gabog commented Nov 10, 2021 •
edited
Loading

Summary

Update in scope repo code owners to use teams rather than individuals.

More specifically:

  • Remove individuals
  • Use only groups and only @microsoft/botframework-sdk
  • Remove old groups (make a list based on what we find in our current repos)

As part of this PR we also made sure the microsoft/botframework-sdk is a member in all the repos below.

Repos in scope

We will not update ownership for the following:

  • emulator
  • webchat
  • Components
  • Composer
  • OBI

TODO: update with any other repos we find later while doing this
@gabog gabog added feature-request A request for new functionality or an enhancement to an existing one. team-agility An issue targeted to reduce friction to the SDK's development process. labels Nov 10, 2021
@gabog gabog self-assigned this Nov 10, 2021
@gabog gabog added this to the R2022.1 milestone Nov 11, 2021
@gabog gabog mentioned this issue Nov 15, 2021
Merged
@gabog gabog added Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete P1 Painful if we don't fix, won't block releasing Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) labels Nov 15, 2021
@gabog gabog linked a pull request Nov 15, 2021 that will close this issue
Adds code owners file to the SDK project #6409
Merged
@gabog gabog removed a link to a pull request Nov 15, 2021
Adds code owners file to the SDK project #6409
Merged
This was referenced Nov 15, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@gabog gabog added Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. and removed feature-request A request for new functionality or an enhancement to an existing one. Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) labels Nov 17, 2021
This was referenced Nov 17, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabog gabog

Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete team-agility An issue targeted to reduce friction to the SDK's development process.
Projects
None yet
Milestone
R2022.1
Development

No branches or pull requests
2 participants
@tracyboehrer @gabog