Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Dialog files have incorrect $schema #780

Closed
chrimc62 opened this issue Mar 4, 2021 · 0 comments · Fixed by #1188
Closed

Dialog files have incorrect $schema #780

chrimc62 opened this issue Mar 4, 2021 · 0 comments · Fixed by #1188
Assignees
Labels
Area: Generators Relating to Yeoman generators. Area: Packages Relating to bot component packages. backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. bug Indicates an unexpected problem or an unintended behavior. Owner: PBX
Milestone

Comments

@chrimc62
Copy link

chrimc62 commented Mar 4, 2021

Describe the bug

Dialog files have an incorrect $schema. They should be referring to the schema generated through merging, instead they are referring to https://raw.githubusercontent.com/microsoft/BotFramework-Composer/stable/Composer/packages/server/schemas/sdk.schema. We have gone to a lot of work to generate a runtime schema and we should use it, something like: ./schemas/sdk.schema. This will allow validation and intellisense in tools like VS code.

image

@cwhitten cwhitten transferred this issue from microsoft/BotFramework-Composer Mar 22, 2021
@cwhitten cwhitten added this to the R13 milestone Mar 22, 2021
@peterinnesmsft peterinnesmsft added Area: Generators Relating to Yeoman generators. Area: Packages Relating to bot component packages. bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Apr 21, 2021
@peterinnesmsft peterinnesmsft removed this from the R13 milestone Apr 27, 2021
@ryanisgrig ryanisgrig added this to the R14 milestone May 5, 2021
@lauren-mills lauren-mills self-assigned this Jun 30, 2021
@lauren-mills lauren-mills modified the milestones: R14, R15 Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Generators Relating to Yeoman generators. Area: Packages Relating to bot component packages. backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. bug Indicates an unexpected problem or an unintended behavior. Owner: PBX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants