Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Mention Support #273

Closed
tracyboehrer opened this issue Jul 23, 2019 · 1 comment · Fixed by #291
Closed

Remove Mention Support #273

tracyboehrer opened this issue Jul 23, 2019 · 1 comment · Fixed by #291
Assignees
@sgellock

Comments

@tracyboehrer
Copy link
Member

tracyboehrer commented Jul 23, 2019 •
edited
Loading

Describe the solution you'd like
Add Remove Mention support as JS and C#. See ActivityExtensions for a reference of Mention related methods. To remove mentions from Activity.Text, see ActivityExtensions.RemoveMentionText and ActivityExtensions.RemoveRecipientMention. Note that in JS it is TurnContext.removeMentionText.

Describe alternatives you've considered
None

Additional context
I have implemented SkypeMentionNormalizeMiddleware on all platforms to correct Skype mentions. The user could still make use of this middleware, but would have to manually remove the mention from Activity.Text to have the same functionality as the other platforms.

[enhancement]
@axelsrz axelsrz mentioned this issue Aug 9, 2019
Merged
@sgellock sgellock self-assigned this Sep 23, 2019
@sgellock
Copy link
Member

looks like this was addressed in #291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgellock sgellock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mentions support in TurnContext microsoft/botbuilder-python
3 participants
@sgellock @tracyboehrer @stevengum