Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSO] Remove 'exchangeToken' validation from OauthPrompt #4137

Closed
ceciliaavila opened this issue Mar 2, 2022 · 0 comments · Fixed by #4138
Closed

[SSO] Remove 'exchangeToken' validation from OauthPrompt #4137

ceciliaavila opened this issue Mar 2, 2022 · 0 comments · Fixed by #4138
Assignees
@JuanAr
Labels
bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Milestone
R16

Comments

@ceciliaavila
Copy link
Collaborator

Versions

4.15.0

Describe the bug

This validation in OAuthPrompt is causing an error in the token exchange between root and skill bots using CloudAdapter.

To Reproduce

Steps to reproduce the behavior:

  1. Add SSO to the SkillDialog samples taking the 82.skills-sso-cloudadapter sample as base.
  2. Log in to the root bot.
  3. Select the Call Skill (with SSO) option.
  4. See the error in the skill bot: OAuthPrompt.recognizeToken(): not supported by the current adapter

Expected behavior

The skill bot should be able to get the token after the exchange.

Additional context

In BotBuilder-DotNet this validation was removed in this commit.
@ceciliaavila ceciliaavila added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Mar 2, 2022
@ceciliaavila ceciliaavila mentioned this issue Mar 2, 2022
Merged
@johnataylor johnataylor added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label Mar 3, 2022
@mrivera-ms mrivera-ms added Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Mar 3, 2022
@mrivera-ms mrivera-ms added this to the R16 milestone Mar 3, 2022
@ceciliaavila ceciliaavila mentioned this issue Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Projects
None yet
Milestone
R16
Development

Successfully merging a pull request may close this issue.

fix: [SSO] Remove 'exchangeToken' validation from OauthPrompt microsoft/botbuilder-js
4 participants
@JuanAr @johnataylor @ceciliaavila @mrivera-ms