Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Register missingProperties custom function to get all variables the template contains (#5518) #3849

Closed
github-actions bot opened this issue Jul 7, 2021 · 2 comments · Fixed by #3885
Closed

port: Register missingProperties custom function to get all variables the template contains (#5518) #3849

github-actions bot opened this issue Jul 7, 2021 · 2 comments · Fixed by #3885
Assignees
@Danieladu
Labels
Area: LG Language generation issues parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

github-actions bot commented Jul 7, 2021

The changes in Register missingProperties custom function to get all variables the template contains (#5518) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #3531

Description

Register a new custom function: missingProperties, which could get all the variables the template contains.

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Jul 7, 2021
@joshgummersall
Copy link
Contributor

@Danieladu I've assigned this one to you for porting to JS, let me know if I can help at all.

@joshgummersall joshgummersall added Area: LG Language generation issues and removed ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jul 7, 2021
@Danieladu
Copy link
Contributor

@Danieladu I've assigned this one to you for porting to JS, let me know if I can help at all.

sure. I would take it

@Danieladu Danieladu mentioned this issue Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danieladu Danieladu

Labels
Area: LG Language generation issues parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
2 participants
@joshgummersall @Danieladu