Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Engineering] npm run test fails with fresh git clone #1732

Closed
Zerryth opened this issue Feb 19, 2020 · 3 comments · Fixed by #1828
Closed

[Engineering] npm run test fails with fresh git clone #1732

Zerryth opened this issue Feb 19, 2020 · 3 comments · Fixed by #1828
Labels
bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing R9 Release 9 - May 15th, 2020
Milestone

Comments

@Zerryth
Copy link
Contributor

Zerryth commented Feb 19, 2020

Versions

What package version of the SDK are you using: 4.7.1
What nodejs version are you using: v12.13.1
What browser version are you using: Chrome Version 80.0.3987.106 (Official Build) (64-bit)
What os are you using: Windows 10

Describe the bug

Can't successfully run all the tests for botbuilder-js.

To Reproduce

Steps to reproduce the behavior:

  1. git clone https://github.com/microsoft/botbuilder-js.git
  2. npm install --global lerna nyc mocha typescript@2.7.2 to install pre-reqs
  3. npm i
  4. npm run test

Then this spits out instead of running tests:
image

Also alternatively tried cloning again, and just following I tried following steps outlined in the "Building the SDK" article in the bb-js Wiki, but this gets you an error even earlier, since it tells you to clone, then run tests, but no installing step before that...

Expected behavior

For tests to successfully run when running npm run test on a newly cloned botbuilder-js repo.

I haven't touched this repo in like 6 months, so maybe there's a step that I'm forgetting and missing...? (Though to be fair, should be documented then if that's the case)

[bug]

@Zerryth Zerryth changed the title Can't npm run build with fresh clone of botbuilder-js? Can't npm run test with fresh clone of botbuilder-js? Feb 19, 2020
@Zerryth
Copy link
Contributor Author

Zerryth commented Feb 19, 2020

This command works from the root mocha "libraries\bot*\tests\**\*.test.js"

Per @stevengum it doesn't look like it's a mocha issue

Also updated the Wiki on Building the SDK to now not ask for those global installs

@stevengum stevengum changed the title Can't npm run test with fresh clone of botbuilder-js? [Engineering] npm run test fails with fresh git clone Feb 21, 2020
@stevengum stevengum added Engineering P1 Painful if we don't fix, won't block releasing R9 Release 9 - May 15th, 2020 labels Feb 21, 2020
@stevengum
Copy link
Member

Possibly related: istanbuljs/nyc#1205

We're currently on "^11.x.y" so we're severely out of date with the latest major version of nyc

image

@stevengum
Copy link
Member

Per my request, @Zerryth updated the wiki to remove the heinous npm install --global ... step...

Thanks @Zerryth 👍

@github-actions github-actions bot added bug Indicates an unexpected problem or an unintended behavior. image labels Mar 4, 2020
@munozemilio munozemilio added this to the R9 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing R9 Release 9 - May 15th, 2020
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants