Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streaming] Move StreamingAdapter logic back into BotFrameworkAdapter #1375

Closed
stevengum opened this issue Oct 30, 2019 · 1 comment
Closed

[Streaming] Move StreamingAdapter logic back into BotFrameworkAdapter #1375

stevengum opened this issue Oct 30, 2019 · 1 comment
Assignees
@stevengum
Labels
P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019
Milestone
R7

Comments

@stevengum
Copy link
Member

Description

  • Move the StreamingAdapter back into BotFrameworkAdapter.

Additional context

The streaming code was removed from the botbuilder library as the streaming implementation was deemed not ready for GA in the 4.6/Ignite milestone.

A developer should not have to choose a different Adapter based on the transport layer they choose to implement. Therefore the logic for streaming should be placed back into the BotFrameworkAdapter.
@stevengum stevengum added P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019 Streaming Extensions labels Oct 30, 2019
@stevengum stevengum self-assigned this Oct 30, 2019
@stevengum stevengum mentioned this issue Oct 30, 2019
Merged
@stevengum
Copy link
Member Author

Closing via #1376.

@munozemilio munozemilio added this to the R7 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevengum stevengum

Labels
P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019
Projects
None yet
Milestone
R7
Development

No branches or pull requests
2 participants
@stevengum @munozemilio