Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Adaptive] Clean up global statics #3558

Closed
vishwacsena opened this issue Mar 13, 2020 · 2 comments · Fixed by #3850 or microsoft/botbuilder-js#2881
Closed

[Adaptive] Clean up global statics #3558

vishwacsena opened this issue Mar 13, 2020 · 2 comments · Fixed by #3850 or microsoft/botbuilder-js#2881
Assignees
@tomlm
Labels
P0 Must Fix. Release-blocker R9 Release 9 - May 15th, 2020 triaged Reviewed by the Triage Team
Milestone
R9

Comments

@vishwacsena
Copy link
Contributor

vishwacsena commented Mar 13, 2020 •
edited by tomlm
Loading

[ ] HostContext should go away
[ ] Make all extension methods base classes good names for usage with non-extension langauges
@vishwacsena vishwacsena added P0 Must Fix. Release-blocker adaptive R9 Release 9 - May 15th, 2020 labels Mar 13, 2020
@vishwacsena vishwacsena added the triaged Reviewed by the Triage Team label Mar 15, 2020
@cleemullins
Copy link
Contributor

@tomlm, @vishwacsena This is a P0 bug with a very scary title and little detail that's not moved forward in 26 days. How can we push this forward?

@cwhitten
Copy link
Member

hey there @vishwacsena @tomlm - what does this issue mean?

@tomlm tomlm changed the title [Adaptive] Evaluate and address issues with multi-tenancy [Adaptive] Remove HostContext Apr 27, 2020
@tomlm tomlm changed the title [Adaptive] Remove HostContext [Adaptive] Clean up global statics Apr 27, 2020
@tomlm tomlm linked a pull request May 1, 2020 that will close this issue
Fix signature of LanguageGenerator base class #3850
Merged
@tomlm tomlm mentioned this issue May 4, 2020
Merged
@munozemilio munozemilio added this to the R9 milestone Jul 1, 2020
@Danieladu Danieladu mentioned this issue Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomlm tomlm

Labels
P0 Must Fix. Release-blocker R9 Release 9 - May 15th, 2020 triaged Reviewed by the Triage Team
Projects
None yet
Milestone
R9
5 participants
@cwhitten @cleemullins @tomlm @vishwacsena @munozemilio