Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoreCLR to build/test matrix #166

Closed
chwarr opened this issue May 19, 2016 · 10 comments
Closed

Add CoreCLR to build/test matrix #166

chwarr opened this issue May 19, 2016 · 10 comments

Comments

@chwarr
Copy link
Member

chwarr commented May 19, 2016

Bond needs to support CoreCLR, so CoreCLR-based builds and tests need to be added to the Travis and AppVeyor build matrices.

Note that not all features of Bond need to work on CoreCLR (e.g., unsafe IO).

@chwarr chwarr changed the title Add CoreCLR to build matrix Add CoreCLR to build/test matrix May 19, 2016
@jterry75
Copy link

jterry75 commented Jun 1, 2016

Will this include updating the nupkg to support dotnet5.4 or netstandard1.3? I would love to be able to use dotnet build for a netcoreapp1.0 and have it not hate me for having a dependency on Bond.CSharp.

As FYI the reason I am doing this is for ASP.NET Core using bond schemas as the transport types.

@chwarr
Copy link
Member Author

chwarr commented Jun 1, 2016

Maybe. Not all of the details have been figured out.

Later today or on Thursday we'll be publishing finer grained packages that split gbc out from Bond.CSharp, which might also solve your problem.

@jterry75
Copy link

jterry75 commented Jun 1, 2016

Actually. I was wrong anyways. On second thought I forgot about how they changed PCL imports for project.json files (everything is still changing). This works for a cross compiled .NET 4.6 and NETCoreApp.

{
  "version": "1.0.0-*",
  "description": "",
  "dependencies": {
    "Bond.CSharp": "4.2.0"
  },
  "frameworks": {
    "net46": {
        "dependencies": {
            "System.Runtime": "4.0.20"
        }
    },
    "dotnet5.4": {
      "imports": [
        "portable-dnxcore50+net45+win8+wp8+wpa81"
      ],
      "dependencies": {
        "System.Diagnostics.Tools": "4.0.1-beta-23516",
        "System.Collections": "4.0.11-beta-23516",
        "System.Runtime": "4.0.21-beta-23516"
      }
    }
  }
}

@chwarr
Copy link
Member Author

chwarr commented Jun 1, 2016

Good to hear.

@sqmgh
Copy link

sqmgh commented Jun 2, 2016

You mention that not all features need to work with CoreCLR. Specifically stating unsafe i/o. However, currently OutputStream and InputStream only seem to exist in Bond.IO.Unsafe, and currently don't seem to be included when you try and pull things into a CoreCLR project.
Is this something that is going to change? Taking a very quick peek at the code doesn't reveal anything that looks unsafe.

@chwarr
Copy link
Member Author

chwarr commented Jun 2, 2016

I've gotten most of Unsafe IO to compile against CoreCLR when allowing unsafe code. However, we'd need to split out the native methods in stream cloning in such a way that we can have different implementations for the various platforms. As currently written, stream cloning will only work on Windows.

@sqmgh
Copy link

sqmgh commented Jun 2, 2016

Ahh, I had not dug that deep. As long as it's on the radar, and not something that is going to be dropped that's fine with me!

@stankovski
Copy link
Member

@chwarr any updates on CoreCLR support?

@chwarr
Copy link
Member Author

chwarr commented Aug 24, 2016

Nothing to report at the moment. .NET Core looks like it is settling down, so we'll want to revisit this.

@chwarr
Copy link
Member Author

chwarr commented Nov 11, 2016

See PR #264 for more complete .NET Core support forthcoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants