-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CoreCLR to build/test matrix #166
Comments
Will this include updating the nupkg to support As FYI the reason I am doing this is for ASP.NET Core using bond schemas as the transport types. |
Maybe. Not all of the details have been figured out. Later today or on Thursday we'll be publishing finer grained packages that split gbc out from Bond.CSharp, which might also solve your problem. |
Actually. I was wrong anyways. On second thought I forgot about how they changed PCL imports for project.json files (everything is still changing). This works for a cross compiled .NET 4.6 and NETCoreApp. {
"version": "1.0.0-*",
"description": "",
"dependencies": {
"Bond.CSharp": "4.2.0"
},
"frameworks": {
"net46": {
"dependencies": {
"System.Runtime": "4.0.20"
}
},
"dotnet5.4": {
"imports": [
"portable-dnxcore50+net45+win8+wp8+wpa81"
],
"dependencies": {
"System.Diagnostics.Tools": "4.0.1-beta-23516",
"System.Collections": "4.0.11-beta-23516",
"System.Runtime": "4.0.21-beta-23516"
}
}
}
} |
Good to hear. |
You mention that not all features need to work with CoreCLR. Specifically stating unsafe i/o. However, currently OutputStream and InputStream only seem to exist in Bond.IO.Unsafe, and currently don't seem to be included when you try and pull things into a CoreCLR project. |
I've gotten most of Unsafe IO to compile against CoreCLR when allowing unsafe code. However, we'd need to split out the native methods in stream cloning in such a way that we can have different implementations for the various platforms. As currently written, stream cloning will only work on Windows. |
Ahh, I had not dug that deep. As long as it's on the radar, and not something that is going to be dropped that's fine with me! |
@chwarr any updates on CoreCLR support? |
Nothing to report at the moment. .NET Core looks like it is settling down, so we'll want to revisit this. |
See PR #264 for more complete .NET Core support forthcoming. |
Bond needs to support CoreCLR, so CoreCLR-based builds and tests need to be added to the Travis and AppVeyor build matrices.
Note that not all features of Bond need to work on CoreCLR (e.g., unsafe IO).
The text was updated successfully, but these errors were encountered: