Support for APIM and WAF deployment

[andrebriggs]

Across multi region we need support for setting up API Management and WAF. We need to be able to configure the APIs to be internal and external. Ideally this would all be with Terraform

[NathanielRose]

API Management Terraform deployment (for Testing) now available:

• Through Arm Resource Terraform Provider
• Through API Management Terraform Provider and Configuration Script

[NathanielRose]

@jred55 I wanted to make sure WAF deployment was completed before we closed this issue, and if there was any feedback from the APIM terraform deployment options.

[NathanielRose]

New updates to APIM may simplify current terraform deployment - hashicorp/terraform-provider-azurerm#3151 Will need to explore changes.

[jmspring]

Per the review on 5/8/2019, the following tasks were identified for the PR:

For Terraform:

• Consolidate modules into cluster/azure
  • tm-waf
  • api-gateway
• Leverage azure-common
• Add subnet for WAF into the existing VNet
  • Given vnet_name, one can add a subnet to an existing vnet without impacting the deployment that created the vnet
• For API Management, use the ARM template
  • Create issue for tracking API management TF provider and migrate away from ARM when possible
• Policy needs to be documented
• Tracking ticket/issue needed on how to test WAF

@shwetams, @ReenuSaluja, @NathanielRose

[NathanielRose]

WAF support completed, stale issue