Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The <filter-mapping> element is not removed when disable the telemetry with application insights #2143

Closed
SummerSun opened this issue Oct 8, 2018 · 4 comments
Assignees
Milestone

Comments

@SummerSun
Copy link
Contributor

SummerSun commented Oct 8, 2018

The element <filter-mapping> in web/WEB-INF/web.xml should be removed when disable the telemetry with application insights.

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<web-app xmlns="http://xmlns.jcp.org/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="4.0" xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_4_0.xsd">
<filter>
    <filter-name>ApplicationInsightsWebFilter</filter-name>
    <filter-class>com.microsoft.applicationinsights.web.internal.WebRequestTrackingFilter</filter-class>
</filter>
<filter-mapping>
    <filter-name>ApplicationInsightsWebFilter</filter-name>
    <url-pattern>/*</url-pattern>
</filter-mapping>
</web-app>
@SummerSun SummerSun self-assigned this Oct 8, 2018
@SummerSun SummerSun added this to the v3.13.0 milestone Oct 8, 2018
@SummerSun SummerSun assigned bsaby and unassigned SummerSun Oct 8, 2018
@SummerSun
Copy link
Contributor Author

SummerSun commented Oct 8, 2018

@bsaby Please help verify

And, the elements <filter> and <filter-mapping> and upcoming <listener> should be added when enabling the telemetry and be removed when disabling the telemetry. We should add these scenarios in our test plan.

@SummerSun SummerSun reopened this Oct 8, 2018
@SummerSun SummerSun changed the title The <filter> element is not removed when disable the telemetry with application insights The <filter-mapping> element is not removed when disable the telemetry with application insights Oct 8, 2018
@SummerSun SummerSun added the fixed label Oct 9, 2018
@bsaby
Copy link

bsaby commented Oct 9, 2018

Build used: Daily536

For IntelliJ, the elements <filter> and <filter-mapping> and <listener> can be added when enabling the telemetry and be removed when disabling the telemetry with AI.

For Eclipse, no element <listener> be added when enabling the telemetry with AI.
image

@bsaby bsaby assigned SummerSun and unassigned bsaby Oct 9, 2018
@SummerSun
Copy link
Contributor Author

@bsaby We did not update it for Eclipse yet since the release of Eclipse is not in the plan. I added the label IntelliJ, then we could track the issue in eclipse in a separated issue.

@bsaby
Copy link

bsaby commented Oct 9, 2018

Tracking Eclispe issue: #2150
For this issue, closed since it has been fixed.

@bsaby bsaby closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants