Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for stage names allows spaces when it should not #441

Open
bbi-XavierElChantiry opened this issue Feb 1, 2022 · 3 comments
Open
Labels
accurate-yaml-validation Fidelity of matching YAML features Area: VsCodeExtension bug Something isn't working

Comments

@bbi-XavierElChantiry
Copy link

image
image
This issue presents when only the azure pipelines extension is enabled.
I am using version 1.195.0 of azure pipelines and version 1.63.2 of vs code.

Proof of concept that can be pasted into vscode to show issue

name: Spaces in a pipeline name

stages:
  # Does not warn that the name is invalid due to spaces!
  - stage: Space in stage name
    displayName: Spaces in a stage display name
    jobs:
      # Correctly warns that the name is invalid because it has spaces
      - job: Spaces in a job name
        displayName: Spaces in a job display name
        steps:
          - pwsh: |
              Write-Host "Inline Powershell script"
            # Correctly warns that the name is invalid because it has spaces
            name: Spaces in a step name
            displayName: Spaces in a step display name

Expected outcome: warning/error that the name is incorrect.
Actual outcome: false sense of security that the name is correct.

@EzzhevNikita EzzhevNikita added bug Something isn't working and removed triage labels Feb 2, 2022
@EzzhevNikita
Copy link

@bbi-XavierElChantiry Thanks for the issue-reporting in this repository, currently we are under issues with higher priority, we will take a look at this ticket once we will have enough capacity.

@winstliu winstliu added the accurate-yaml-validation Fidelity of matching YAML features label Feb 3, 2022
@winstliu
Copy link
Member

winstliu commented Feb 3, 2022

@EzzhevNikita would you recommend opening a ticket on Developer Community, since we just happen to be one of the consumers of the Azure DevOps yamlschema API endpoint, or is this issue sufficient?

@EzzhevNikita
Copy link

@50Wliu Yes, it seems like the YAML schema requires changes to fix this issue.

@bbi-XavierElChantiry Could you please open a ticket in Developer Community since this issue requires changes in YAML schema, which is not owned by our team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accurate-yaml-validation Fidelity of matching YAML features Area: VsCodeExtension bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants