Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure resource group deployment v2 task shows warnings #14536

Open
trolleyboy opened this issue Mar 5, 2021 · 29 comments
Open

Azure resource group deployment v2 task shows warnings #14536

trolleyboy opened this issue Mar 5, 2021 · 29 comments
Assignees

Comments

@trolleyboy
Copy link

trolleyboy commented Mar 5, 2021

Note

Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo

For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks

If you have an issue or request for the Azure Pipelines service, use developer community instead:

https://developercommunity.visualstudio.com/spaces/21/index.html )

Required Information

Entering this information will route you directly to the right team and expedite traction.

Question, Bug, or Feature?
Type: Bug

Enter Task Name: AzureResourceGroupDeploymentV2

list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks

Environment

  • Server - Azure Pipelines or TFS on-premises?
    Azure Pipelines
  • Agent -
    Hosted - windows-latest

Issue Description

[Include task name(s), screenshots and any other relevant details]
Warnings showing during deployments:

##[warning]Resource file has already set to: D:\a\_tasks\AzureResourceGroupDeployment_94a74903-f93f-4075-884f-dc11f34058b4\2.184.0\node_modules\azure-pipelines-tasks-azure-arm-rest-v2\module.json

and

(node:1252) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

The task does complete successfully.

@github-actions github-actions bot added Area: Release bug environment:need-to-triage Issues need to be triage by environment-deployment team labels Mar 5, 2021
@AmrutaKawade AmrutaKawade removed the environment:need-to-triage Issues need to be triage by environment-deployment team label Mar 5, 2021
@AmrutaKawade AmrutaKawade assigned bishal-pdMSFT and unassigned nadesu Mar 5, 2021
@emilpeder
Copy link

Just input: We see the same thing. Seems to be a consequence of moving from version 2.182.0 to 2.184.0 of the task.

@bishal-pdMSFT
Copy link
Contributor

@ddivanshu can you please take a look here

@alfhj
Copy link

alfhj commented Mar 18, 2021

Any update? This doesn't seem to affect the pipelines, but it creates some clutter. Related issue: #14284

@ddivanshu
Copy link
Contributor

Since this is warning and not affecting pipeline behavior, we are not currently prioritising it. However based upon code changes , fix does n't seems to be too hard.Will be resolving it somewhere in April.

@DavidAtTfL
Copy link

@ddivanshu thank you for the update and the prognosis!

Although as you say this doesn't affect pipeline behaviour, it definitely affects developer behaviour! Our pipelines are drowning in false alarms and it has already become the cases the our teams just ignore warnings on pipelines now ("oh that's just another bug with the task"). False warnings are more than a nuisance.

All this to really just ask for an update 😄. Thanks for looking into it.

@alfhj
Copy link

alfhj commented Apr 30, 2021

@DavidAtTfL for the time being, this task does not produce these warnings: AzureResourceManagerTemplateDeploymentV3

@SebastianSchuetze
Copy link

@ddivanshu any update on the fix?

@Jernik
Copy link

Jernik commented Sep 21, 2021

We are still seeing this warning in our pipelines using the AzureResourceGroupDeployment@2 task. Is there any update for resolution?

@simonvane
Copy link

Hi @ddivanshu, is there any update on this. In March you mentioned you'd be fixing it in April and it's now October but the warning still occurs.

@DavidAtTfL explained the consequence of the warning very well:

Although as you say this doesn't affect pipeline behaviour, it definitely affects developer behaviour! Our pipelines are drowning in false alarms and it has already become the cases the our teams just ignore warnings on pipelines now ("oh that's just another bug with the task"). False warnings are more than a nuisance.

I am here spending time researching to see if this is an issue and I know that other developers have done too (then forgotten the outcome, hence I'm looking now).

Thanks, @alfhj for the suggestion to update to v3, very helpful. That's going to take some time, unfortunately. We have a lot of pipelines affected by this.

@Nick-Griffiths
Copy link

Hi @ddivanshu, my team are having the same problems with these warnings - can you please confirm when this issue will be fixed?

@craigforr
Copy link

We are seeing this in our Linux pipeline jobs as well:

##[warning]Resource file has already set to: /home/vsts/work/_tasks/AzureResourceGroupDeployment_XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/2.192.1/node_modules/azure-pipelines-tasks-azure-arm-rest-v2/module.json

Pool:

Pool: Azure Pipelines
Image: ubuntu-latest
Agent: Hosted Agent

Task:

Task         : Azure resource group deployment
Description  : Deploy an Azure Resource Manager (ARM) template to a resource group and manage virtual machines
Version      : 2.192.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment

I can provide additional information if desired.

@Stevonix
Copy link

Hi,

we are facing the same problems. Even after updating to V3 the deprication warning is still there.

Please fix this.

regards
Stefan

Task         : ARM template deployment
Description  : Deploy an Azure Resource Manager (ARM) template to all the deployment scopes
Version      : 3.198.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment
ARM Service Connection deployment scope - Subscription
Checking if the following resource group exists: xxxx.
Resource group exists: true.
Creating deployment parameters.
(node:7140) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Starting template validation.
Deployment name is XXXXX
Template deployment validation was completed successfully.

@ericvruder
Copy link

Having the same issue here as well, any news?

==============================================================================
Task         : Azure resource group deployment
Description  : Deploy an Azure Resource Manager (ARM) template to a resource group and manage virtual machines
Version      : 2.198.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment
==============================================================================
##[warning]Resource file has already set to: D:\a\_tasks\AzureResourceGroupDeployment_94a74903-f93f-4075-884f-dc11f34058b4\2.198.0\node_modules\azure-pipelines-tasks-azure-arm-rest-v2\module.json
Checking if the following resource group exists: test.
Resource group exists: true.
Creating deployment parameters.
The detected encoding for file 'D:\a\1\Test\azuredeploy.json' is 'utf-8'
(node:4888) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Starting template validation

@CameronDwyer
Copy link

CameronDwyer commented Jul 20, 2022

6 months further on and this warning is still causing wasted time for development teams. Would love to see it progressed.

==============================================================================
Task         : Azure resource group deployment
Description  : Deploy an Azure Resource Manager (ARM) template to a resource group and manage virtual machines
Version      : 2.198.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment
==============================================================================
##[warning]Resource file has already set to: /home/vsts/work/_tasks/AzureResourceGroupDeployment_94a74903-f93f-4075-884f-dc11f34058b4/2.198.0/node_modules/azure-pipelines-tasks-azure-arm-rest-v2/module.json

@meizenga
Copy link

meizenga commented Sep 23, 2022

Issue still exists in v3.209.0:

==============================================================================
Task         : ARM template deployment
Description  : Deploy an Azure Resource Manager (ARM) template to all the deployment scopes
Version      : 3.209.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment
==============================================================================
(node:4528) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

@mattleibow
Copy link

I am sure this is going to increase the security risk with all these fake warnings hiding the real warnings:

image

@timmkrause
Copy link

timmkrause commented Nov 2, 2022

They don't care about us anymore. GitHub all the things...

Move or be left behind.

@hilari0n
Copy link

hilari0n commented Nov 14, 2022

A similar issue is also happening for other types of tasks, e.g. Azure KeyVault (#17127), Gradle (#13916, which also mentions, that NuGet Authentication task is also affected).

What might help this issue being addressed with more priority, is all interested people up-voting the issue. Which means clicking the "thumbs-up" on the original post (not posting a "+1" or "me too" comment).
The Gradle issue mentioned above, has 15 votes and seems to be addressed. This one has only 5 at the moment.

@pwrmiller
Copy link

PipAuthenticate is also affected.

@uchitha
Copy link

uchitha commented Feb 8, 2023

Bump+. We use this under a template task and its status is returned as unsuccessful causing issues and mis understandings. Appreciate a fix or workaround soon.

@MmAtBosch
Copy link

Any update after two years?

@ianpurvis1976
Copy link

2years 4 months and still not closed?

@ArturAdam
Copy link

+1

@yo1-markenstein
Copy link

:tumbleweed:

@billpieper
Copy link

+1

1 similar comment
@v-caxian
Copy link

v-caxian commented Feb 1, 2024

+1

@chadbaldwin
Copy link

chadbaldwin commented Apr 4, 2024

@fmad
Copy link

fmad commented Jun 27, 2024

Any news on this? 3 years seems a tad too much, even for a non-priority task. Yes, it is just a warning but why do we need this cluttering our pipelines? This is what we get - we can't even SEE the actual stages and what's happening until we scroll the page down. EVERY. SINGLE. TIME. It is really annoying, even if it does not stop or break the actual build. This is using Kubernetes@1 v. 1.241.5

image

@btull89
Copy link

btull89 commented Sep 24, 2024

I'm also seeing this warning in my build pipelines.
Resource file has already set to: D:\a\_tasks\DotNetCoreCLI_5541a522-603c-47ad-91fc-a4b1d163081b\2.245.1\node_modules\azure-pipelines-tasks-packaging-common\module.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests